Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 962613002: add interceptors which do not mask existing properties (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

add interceptors which do not mask existing properties R=verwaest@chromium.org BUG= Committed: https://crrev.com/0880d4da26d5db48c9c1784e6c4d53aaf473ef59 Cr-Commit-Position: refs/heads/master@{#27271}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : whoops #

Patch Set 7 : #

Patch Set 8 : first test #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Total comments: 1

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -52 lines) Patch
M include/v8.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +11 lines, -1 line 0 comments Download
M src/api.cc View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +15 lines, -9 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +23 lines, -1 line 0 comments Download
M src/ic/ic.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -24 lines 0 comments Download
M src/lookup.h View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +23 lines, -9 lines 0 comments Download
M src/lookup.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +41 lines, -5 lines 0 comments Download
M src/lookup-inl.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +24 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +127 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dcarney
ptal - the handler-compiler change is hacky atm as i didn't want to deal with ...
5 years, 9 months ago (2015-03-11 10:48:27 UTC) #2
Toon Verwaest
The lookup iterator side of things looks fine. https://codereview.chromium.org/962613002/diff/200001/src/lookup-inl.h File src/lookup-inl.h (right): https://codereview.chromium.org/962613002/diff/200001/src/lookup-inl.h#newcode96 src/lookup-inl.h:96: !isolate_->IsInternallyUsedPropertyName(name_)) ...
5 years, 9 months ago (2015-03-11 14:09:35 UTC) #3
dcarney
okay, ptal
5 years, 9 months ago (2015-03-18 11:15:35 UTC) #4
Toon Verwaest
lgtm
5 years, 9 months ago (2015-03-18 12:42:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962613002/260001
5 years, 9 months ago (2015-03-18 12:45:45 UTC) #7
commit-bot: I haz the power
Committed patchset #14 (id:260001)
5 years, 9 months ago (2015-03-18 12:50:47 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 12:50:59 UTC) #9
Message was sent while issue was closed.
Patchset 14 (id:??) landed as
https://crrev.com/0880d4da26d5db48c9c1784e6c4d53aaf473ef59
Cr-Commit-Position: refs/heads/master@{#27271}

Powered by Google App Engine
This is Rietveld 408576698