Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 962593005: CpuProfiler: do not calculate positions if it is not necessary (TryInline part). (Closed)

Created:
5 years, 9 months ago by loislo
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CpuProfiler: do not calculate positions if it is not necessary (TryInline part). TryInline needed position only for the case when we track positions. We can drop the position argument and use the current position from GraphBuilder. The only problem that it doesn't match with the inline point. The reason of that was the fact that builder had moved the position forward by visiting arguments expressions. I fixed this by restoring the current positon in HOptimizedGraphBuilderWithPositions::Visit* BUG=452067 LOG=n Committed: https://crrev.com/cbda41c88aa0813be7a4ecc0aeb1559000680c2b Cr-Commit-Position: refs/heads/master@{#26953}

Patch Set 1 #

Patch Set 2 : unnecessary change was removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -59 lines) Patch
M src/compiler.cc View 2 chunks +23 lines, -15 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen.cc View 8 chunks +20 lines, -42 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
loislo
PTAL
5 years, 9 months ago (2015-02-27 13:16:41 UTC) #2
yurys
looks good, but someone more familiar with the code should review this.
5 years, 9 months ago (2015-02-27 13:23:54 UTC) #3
Vyacheslav Egorov (Google)
lgtm
5 years, 9 months ago (2015-02-27 13:34:37 UTC) #6
Sven Panne
lgtm
5 years, 9 months ago (2015-03-03 07:50:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962593005/20001
5 years, 9 months ago (2015-03-03 07:51:06 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 08:42:35 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 08:42:50 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cbda41c88aa0813be7a4ecc0aeb1559000680c2b
Cr-Commit-Position: refs/heads/master@{#26953}

Powered by Google App Engine
This is Rietveld 408576698