content/browser/push_messaging/push_messaging_router.cc - Issue 962543005: Service Worker: Add metrics and timeout for starting a Service Worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/push_messaging/push_messaging_router.cc

Issue 962543005: Service Worker: Add metrics and timeout for starting a Service Worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: self-review Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/push_messaging/push_messaging_message_filter.cc ('k') | content/browser/service_worker/embedded_worker_instance.h » ('j') | content/browser/service_worker/embedded_worker_instance.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/push_messaging/push_messaging_router.cc

diff --git a/content/browser/push_messaging/push_messaging_router.cc b/content/browser/push_messaging/push_messaging_router.cc

index 085ee7d21799d11c0e2677570cdd621fcf47af51..72a081d8b882cc384dd70812bb6b2f2826acb4ef 100644

--- a/content/browser/push_messaging/push_messaging_router.cc

+++ b/content/browser/push_messaging/push_messaging_router.cc

@@ -107,6 +107,7 @@ void PushMessagingRouter::DeliverMessageEnd(

case SERVICE_WORKER_ERROR_PROCESS_NOT_FOUND:

case SERVICE_WORKER_ERROR_NOT_FOUND:

case SERVICE_WORKER_ERROR_IPC_FAILED:

+ case SERVICE_WORKER_ERROR_TIMEOUT:

delivery_status = PUSH_DELIVERY_STATUS_SERVICE_WORKER_ERROR;

break;

case SERVICE_WORKER_ERROR_EXISTS:

@@ -115,6 +116,7 @@ void PushMessagingRouter::DeliverMessageEnd(

case SERVICE_WORKER_ERROR_NETWORK:

case SERVICE_WORKER_ERROR_SECURITY:

case SERVICE_WORKER_ERROR_STATE:

+ case SERVICE_WORKER_ERROR_MAX_VALUE:

NOTREACHED() << "Got unexpected error code: " << service_worker_status

<< " " << ServiceWorkerStatusToString(service_worker_status);

delivery_status = PUSH_DELIVERY_STATUS_SERVICE_WORKER_ERROR;