Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: content/renderer/service_worker/embedded_worker_context_client.cc

Issue 962543005: Service Worker: Add metrics and timeout for starting a Service Worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync again Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/embedded_worker_context_client.cc
diff --git a/content/renderer/service_worker/embedded_worker_context_client.cc b/content/renderer/service_worker/embedded_worker_context_client.cc
index b84340b5bcb8f166fcea25cad1f18bdecbfcd139..7aed37e72e868ec1fc27740c2af067c7595f0532 100644
--- a/content/renderer/service_worker/embedded_worker_context_client.cc
+++ b/content/renderer/service_worker/embedded_worker_context_client.cc
@@ -208,13 +208,6 @@ void EmbeddedWorkerContextClient::workerContextStarted(
WorkerTaskRunner::Instance()->CurrentWorkerId(),
provider_context_->provider_id()));
- // Schedule a task to send back WorkerStarted asynchronously,
- // so that at the time we send it we can be sure that the worker
- // script has been evaluated and worker run loop has been started.
- worker_task_runner_->PostTask(
- FROM_HERE,
- base::Bind(&EmbeddedWorkerContextClient::SendWorkerStarted,
- weak_factory_.GetWeakPtr()));
TRACE_EVENT_ASYNC_STEP_INTO0(
"ServiceWorker",
"EmbeddedWorkerContextClient::StartingWorkerContext",
@@ -225,6 +218,13 @@ void EmbeddedWorkerContextClient::workerContextStarted(
void EmbeddedWorkerContextClient::didEvaluateWorkerScript(bool success) {
Send(new EmbeddedWorkerHostMsg_WorkerScriptEvaluated(
embedded_worker_id_, success));
+
+ // Schedule a task to send back WorkerStarted asynchronously,
+ // so that at the time we send it we can be sure that the
+ // worker run loop has been started.
+ worker_task_runner_->PostTask(
+ FROM_HERE, base::Bind(&EmbeddedWorkerContextClient::SendWorkerStarted,
+ weak_factory_.GetWeakPtr()));
}
void EmbeddedWorkerContextClient::willDestroyWorkerContext() {
« no previous file with comments | « content/common/service_worker/service_worker_status_code.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698