content/browser/service_worker/service_worker_register_job.cc - Issue 962543005: Service Worker: Add metrics and timeout for starting a Service Worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 962543005: Service Worker: Add metrics and timeout for starting a Service Worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_instance.cc ('k') | content/browser/service_worker/service_worker_registration_status.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_register_job.cc

diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc

index 986cae358c58c96cb9629b1820f781857277dbb2..cec77ae059db1c41b6184fd40a26988953bc5801 100644

--- a/content/browser/service_worker/service_worker_register_job.cc

+++ b/content/browser/service_worker/service_worker_register_job.cc

@@ -354,6 +354,10 @@ void ServiceWorkerRegisterJob::OnStartWorkerFinished(

if (message.empty())

message = kFetchScriptError;

}

+ if (status == SERVICE_WORKER_ERROR_TIMEOUT)

+ message = "Timed out while trying to start the Service Worker.";

Complete(status, message);

}

@@ -389,8 +393,6 @@ void ServiceWorkerRegisterJob::InstallAndContinue() {

void ServiceWorkerRegisterJob::OnInstallFinished(

ServiceWorkerStatusCode status) {

- // TODO(kinuko,falken): For some error cases (e.g. ServiceWorker is

- // unexpectedly terminated) we may want to retry sending the event again.

if (status != SERVICE_WORKER_OK) {

// "8. If installFailed is true, then:..."

Complete(status);