Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2045)

Unified Diff: content/browser/service_worker/embedded_worker_instance.h

Issue 962543005: Service Worker: Add metrics and timeout for starting a Service Worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync again Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_instance.h
diff --git a/content/browser/service_worker/embedded_worker_instance.h b/content/browser/service_worker/embedded_worker_instance.h
index 24717f8eb17cf74eaa246323ba54d9189204bab3..96de5ac62dc820826a42ca5a523b2c8a14e869b4 100644
--- a/content/browser/service_worker/embedded_worker_instance.h
+++ b/content/browser/service_worker/embedded_worker_instance.h
@@ -53,6 +53,19 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
STOPPING,
};
+ // This enum is used in UMA histograms, so don't change the order or remove
+ // entries.
+ enum StartingPhase {
+ NOT_STARTING,
+ ALLOCATING_PROCESS,
+ REGISTERING_TO_DEVTOOLS,
+ SENT_START_WORKER,
+ SCRIPT_DOWNLOADING,
+ SCRIPT_LOADED,
+ SCRIPT_EVALUATED,
+ STARTING_PHASE_MAX_VALUE,
+ };
+
class Listener {
public:
virtual ~Listener() {}
@@ -106,6 +119,10 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
int embedded_worker_id() const { return embedded_worker_id_; }
Status status() const { return status_; }
+ StartingPhase starting_phase() const {
+ DCHECK_EQ(STARTING, status());
+ return starting_phase_;
+ }
int process_id() const { return process_id_; }
int thread_id() const { return thread_id_; }
int worker_devtools_agent_route_id() const;
@@ -115,10 +132,14 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
void RemoveListener(Listener* listener);
void set_devtools_attached(bool attached) { devtools_attached_ = attached; }
+ bool devtools_attached() const { return devtools_attached_; }
// Called when the script load request accessed the network.
void OnNetworkAccessedForScriptLoad();
+ static std::string StatusToString(Status status);
+ static std::string StartingPhaseToString(StartingPhase phase);
+
private:
typedef ObserverList<Listener> ListenerList;
class DevToolsProxy;
@@ -202,6 +223,7 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
scoped_refptr<EmbeddedWorkerRegistry> registry_;
const int embedded_worker_id_;
Status status_;
+ StartingPhase starting_phase_;
// Current running information. -1 indicates the worker is not running.
int process_id_;
« no previous file with comments | « content/browser/push_messaging/push_messaging_router.cc ('k') | content/browser/service_worker/embedded_worker_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698