content/common/service_worker/service_worker_status_code.h - Issue 962543005: Service Worker: Add metrics and timeout for starting a Service Worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_status_code.h

Issue 962543005: Service Worker: Add metrics and timeout for starting a Service Worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « content/browser/service_worker/service_worker_version_unittest.cc ('k') | content/common/service_worker/service_worker_status_code.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/service_worker/service_worker_status_code.h

diff --git a/content/common/service_worker/service_worker_status_code.h b/content/common/service_worker/service_worker_status_code.h

index 1e9cdd51a6caccbe555fed48e4ee0d4a119808fc..2a9f0edfb6564afd7dcfe63918feeb87878316c1 100644

--- a/content/common/service_worker/service_worker_status_code.h

+++ b/content/common/service_worker/service_worker_status_code.h

@@ -10,6 +10,8 @@

namespace content {

// Generic service worker operation statuses.

+// This enum is used in UMA histograms, so don't change the order or remove

+// entries.

enum ServiceWorkerStatusCode {

// Operation succeeded.

SERVICE_WORKER_OK,

@@ -54,6 +56,11 @@ enum ServiceWorkerStatusCode {

// An error triggered by invalid worker state.

SERVICE_WORKER_ERROR_STATE,

+ // The Service Worker took too long to finish a task.

+ SERVICE_WORKER_ERROR_TIMEOUT,

+ SERVICE_WORKER_ERROR_MAX_VALUE

};

CONTENT_EXPORT const char* ServiceWorkerStatusToString(