content/browser/service_worker/service_worker_registration_status.cc - Issue 962543005: Service Worker: Add metrics and timeout for starting a Service Worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration_status.cc

Issue 962543005: Service Worker: Add metrics and timeout for starting a Service Worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_register_job.cc ('k') | content/browser/service_worker/service_worker_version.h » ('j') | content/browser/service_worker/service_worker_version.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration_status.cc

diff --git a/content/browser/service_worker/service_worker_registration_status.cc b/content/browser/service_worker/service_worker_registration_status.cc

index 84f293ed63ded17874d9bcc8b36d4989bffb15ee..3c92a5dfffc2a75906bdc9ab68862f7b850e5da7 100644

--- a/content/browser/service_worker/service_worker_registration_status.cc

+++ b/content/browser/service_worker/service_worker_registration_status.cc

@@ -47,6 +47,10 @@ void GetServiceWorkerRegistrationStatusResponse(

*error_type = WebServiceWorkerError::ErrorTypeSecurity;

return;

+ case SERVICE_WORKER_ERROR_TIMEOUT:

+ *error_type = WebServiceWorkerError::ErrorTypeTimeout;

+ return;

case SERVICE_WORKER_ERROR_ABORT:

case SERVICE_WORKER_ERROR_IPC_FAILED:

case SERVICE_WORKER_ERROR_FAILED:

@@ -54,6 +58,7 @@ void GetServiceWorkerRegistrationStatusResponse(

case SERVICE_WORKER_ERROR_EXISTS:

case SERVICE_WORKER_ERROR_EVENT_WAITUNTIL_REJECTED:

case SERVICE_WORKER_ERROR_STATE:

+ case SERVICE_WORKER_ERROR_MAX_VALUE:

// Unexpected, or should have bailed out before calling this, or we don't

// have a corresponding blink error code yet.

break; // Fall through to NOTREACHED().