Service Worker: Add metrics and timeout for starting a Service Worker.

content/browser/push_messaging/push_messaging_message_filter.cc

Index: content/browser/push_messaging/push_messaging_message_filter.cc
diff --git a/content/browser/push_messaging/push_messaging_message_filter.cc b/content/browser/push_messaging/push_messaging_message_filter.cc
index 7aaa79036513444f7bd3a70e3954bb17794c5e02..66ff08135ce9869679ce15b93e13a8aa44d5adb8 100644
--- a/content/browser/push_messaging/push_messaging_message_filter.cc
+++ b/content/browser/push_messaging/push_messaging_message_filter.cc
@@ -552,6 +552,8 @@ void PushMessagingMessageFilter::UnregisterHavingGottenSenderId(
     case SERVICE_WORKER_ERROR_SECURITY:
     case SERVICE_WORKER_ERROR_EVENT_WAITUNTIL_REJECTED:
     case SERVICE_WORKER_ERROR_STATE:
+    case SERVICE_WORKER_ERROR_TIMEOUT:

[Peter Beverloo, 2015/03/02 14:23:37]

nit: Please add a TODO for us to handle SERVICE_WORKER_ERROR_TIMEOUT more
gracefully, if this is also going to be used for the 30-second execution
timeout. It's a bit harsh to unregister a developer's push registration if their
JavaScript executes for >30s.

I'll add a task for us to handle this on the Push side.

[Peter Beverloo, 2015/03/02 14:26:01]

Scrap that, I was reading the wrong function :-). lgtm!

[falken, 2015/03/02 14:44:03]

OK :) I just want to confirm this is OK... currently the 30 second timeout will
stop a service worker that's busy executing JS. If this function was a callback
registered to the ServiceWorkerVersion at that time, the current implementation
will call it with SERVICE_WORKER_ERROR_FAILED (see
ServiceWorkerVersion::OnStopped).

I guess if this callback isn't for an operation that blocks on the worker doing
JavaScript, then the timeout shouldn't be an issue.

Also, in future patches, I'm planning to change the error code for 30-second
timeout to SERVICE_WORKER_ERROR_TIMEOUT to reflect the reason the worker was
stopped.

+    case SERVICE_WORKER_ERROR_MAX_VALUE:
       NOTREACHED() << "Got unexpected error code: " << service_worker_status
                    << " " << ServiceWorkerStatusToString(service_worker_status);
       DidUnregister(request_id, PUSH_UNREGISTRATION_STATUS_STORAGE_ERROR);
@@ -733,6 +735,8 @@ void PushMessagingMessageFilter::DidGetRegistration(
     case SERVICE_WORKER_ERROR_SECURITY:
     case SERVICE_WORKER_ERROR_EVENT_WAITUNTIL_REJECTED:
     case SERVICE_WORKER_ERROR_STATE:
+    case SERVICE_WORKER_ERROR_TIMEOUT:
+    case SERVICE_WORKER_ERROR_MAX_VALUE:
       NOTREACHED() << "Got unexpected error code: " << service_worker_status
                    << " " << ServiceWorkerStatusToString(service_worker_status);
       get_status = PUSH_GETREGISTRATION_STATUS_STORAGE_ERROR;