Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: Source/modules/webmidi/MIDIAccess.h

Issue 962523005: Web MIDI: add open() and close() to MIDIPort (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: review #14 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/webmidi/requestmidiaccess-expected.txt ('k') | Source/modules/webmidi/MIDIAccess.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webmidi/MIDIAccess.h
diff --git a/Source/modules/webmidi/MIDIAccess.h b/Source/modules/webmidi/MIDIAccess.h
index abb879c6448fe35dbd5ca632d4ea5d30aa6d6e31..ca7c3035a09363c5ca9fadb76248c0d81000d245 100644
--- a/Source/modules/webmidi/MIDIAccess.h
+++ b/Source/modules/webmidi/MIDIAccess.h
@@ -59,7 +59,7 @@ public:
access->suspendIfNeeded();
return access;
}
- virtual ~MIDIAccess();
+ ~MIDIAccess() override;
MIDIInputMap* inputs() const;
MIDIOutputMap* outputs() const;
@@ -69,24 +69,24 @@ public:
bool sysexEnabled() const { return m_sysexEnabled; }
// EventTarget
- virtual const AtomicString& interfaceName() const override { return EventTargetNames::MIDIAccess; }
- virtual ExecutionContext* executionContext() const override { return ActiveDOMObject::executionContext(); }
+ const AtomicString& interfaceName() const override { return EventTargetNames::MIDIAccess; }
+ ExecutionContext* executionContext() const override { return ActiveDOMObject::executionContext(); }
// ActiveDOMObject
- virtual void stop() override;
+ void stop() override;
// MIDIAccessorClient
- virtual void didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool isActive) override;
- virtual void didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool isActive) override;
- virtual void didSetInputPortState(unsigned portIndex, bool isActive) override;
- virtual void didSetOutputPortState(unsigned portIndex, bool isActive) override;
- virtual void didStartSession(bool success, const String& error, const String& message) override
+ void didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version, MIDIAccessor::MIDIPortState) override;
+ void didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version, MIDIAccessor::MIDIPortState) override;
+ void didSetInputPortState(unsigned portIndex, MIDIAccessor::MIDIPortState) override;
+ void didSetOutputPortState(unsigned portIndex, MIDIAccessor::MIDIPortState) override;
+ void didStartSession(bool success, const String& error, const String& message) override
{
// This method is for MIDIAccess initialization: MIDIAccessInitializer
// has the implementation.
ASSERT_NOT_REACHED();
}
- virtual void didReceiveMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStamp) override;
+ void didReceiveMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStamp) override;
// |timeStampInMilliseconds| is in the same time coordinate system as performance.now().
void sendMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStampInMilliseconds);
« no previous file with comments | « LayoutTests/webmidi/requestmidiaccess-expected.txt ('k') | Source/modules/webmidi/MIDIAccess.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698