Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 962523002: [gyp] Disable warnings generated by third party ICU code. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gyp] Disable warnings generated by third party ICU code. R=svenpanne@chromium.org Committed: https://crrev.com/166dcd339fd490aee2c9e75c5017bfd550f58c00 Cr-Commit-Position: refs/heads/master@{#26871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M build/standalone.gypi View 4 chunks +25 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 10 months ago (2015-02-26 07:56:07 UTC) #1
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-26 07:56:19 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-02-26 07:59:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962523002/1
5 years, 10 months ago (2015-02-26 08:00:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 08:19:31 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 08:19:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/166dcd339fd490aee2c9e75c5017bfd550f58c00
Cr-Commit-Position: refs/heads/master@{#26871}

Powered by Google App Engine
This is Rietveld 408576698