Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 962513002: IDL: Add test for attribute that "inherits its getter" (Closed)

Created:
5 years, 10 months ago by Jens Widell
Modified:
5 years, 10 months ago
Reviewers:
haraken, philipj_slow
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Add test for attribute that "inherits its getter" BUG=462097 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M Source/bindings/tests/idls/core/TestInterfaceNode.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jens Widell
PTAL
5 years, 10 months ago (2015-02-26 07:53:00 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-26 07:54:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962513002/1
5 years, 10 months ago (2015-02-26 07:58:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190893
5 years, 10 months ago (2015-02-26 09:38:03 UTC) #6
philipj_slow
5 years, 10 months ago (2015-02-26 14:13:50 UTC) #7
Message was sent while issue was closed.
LGTM, thanks Jens!

Powered by Google App Engine
This is Rietveld 408576698