Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 962503005: Clean-up: Remove accelerated subscriber switch for tab/desktop capture. (Closed)

Created:
5 years, 9 months ago by miu
Modified:
5 years, 9 months ago
Reviewers:
hubbe
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean-up: Remove accelerated subscriber switch for tab/desktop capture. Removes a compile-time switch and associated logic that was necessary in the pre-Aura days where content change signals were not reliable. Committed: https://crrev.com/67cc124f207b423ab020b44a91bc4a72f9dec32b Cr-Commit-Position: refs/heads/master@{#318594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -117 lines) Patch
M content/browser/media/capture/content_video_capture_device_core.h View 4 chunks +2 lines, -11 lines 0 comments Download
M content/browser/media/capture/content_video_capture_device_core.cc View 5 chunks +7 lines, -13 lines 0 comments Download
M content/browser/media/capture/video_capture_oracle.h View 3 chunks +1 line, -4 lines 0 comments Download
M content/browser/media/capture/video_capture_oracle.cc View 3 chunks +4 lines, -14 lines 0 comments Download
M content/browser/media/capture/video_capture_oracle_unittest.cc View 13 chunks +12 lines, -67 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.cc View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
miu
hubbe: PTAL at long-time wanting TODO.
5 years, 9 months ago (2015-02-27 01:49:59 UTC) #2
hubbe
lgtm
5 years, 9 months ago (2015-02-28 00:34:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962503005/1
5 years, 9 months ago (2015-02-28 03:12:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-28 04:46:11 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 04:46:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67cc124f207b423ab020b44a91bc4a72f9dec32b
Cr-Commit-Position: refs/heads/master@{#318594}

Powered by Google App Engine
This is Rietveld 408576698