Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.h

Issue 962453002: Update permission bubble anchor when omnibar is hidden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert to UpdateAnchorPosition in BrowserView Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.h
diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.h b/chrome/browser/ui/views/website_settings/permissions_bubble_view.h
index 9091b56f07a8375e391e7d3563a4368653bf80a5..0b2621396c91149085cf4aa7f5ee0508e759f4fe 100644
--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.h
+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.h
@@ -10,19 +10,22 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "chrome/browser/ui/website_settings/permission_bubble_view.h"
+#include "ui/views/bubble/bubble_border.h"
namespace views {
class View;
}
+class Browser;
class PermissionsBubbleDelegateView;
class PermissionBubbleViewViews : public PermissionBubbleView {
public:
- PermissionBubbleViewViews(views::View* anchor_view,
- const std::string& languages);
+ explicit PermissionBubbleViewViews(Browser* browser);
~PermissionBubbleViewViews() override;
+ void UpdateAnchorPosition();
msw 2015/03/23 19:34:53 nit: add a simple comment like "Updates the anchor
hcarmona 2015/03/23 20:47:45 Done.
+
// PermissionBubbleView:
void SetDelegate(Delegate* delegate) override;
void Show(const std::vector<PermissionBubbleRequest*>& requests,
@@ -37,10 +40,12 @@ class PermissionBubbleViewViews : public PermissionBubbleView {
void Deny();
private:
- views::View* anchor_view_;
+ views::View* GetAnchorView();
+ views::BubbleBorder::Arrow GetAnchorArrow();
+
+ Browser* browser_;
Delegate* delegate_;
PermissionsBubbleDelegateView* bubble_delegate_;
- const std::string languages_;
DISALLOW_COPY_AND_ASSIGN(PermissionBubbleViewViews);
};
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/website_settings/permissions_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698