Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.h

Issue 962453002: Update permission bubble anchor when omnibar is hidden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update Fullscreen Parent Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.h
diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.h b/chrome/browser/ui/views/website_settings/permissions_bubble_view.h
index 9091b56f07a8375e391e7d3563a4368653bf80a5..655fce87f64d20df9cc0e00710f9898d6b26701f 100644
--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.h
+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.h
@@ -10,6 +10,7 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "chrome/browser/ui/website_settings/permission_bubble_view.h"
+#include "ui/views/bubble/bubble_border.h"
namespace views {
class View;
@@ -19,10 +20,12 @@ class PermissionsBubbleDelegateView;
class PermissionBubbleViewViews : public PermissionBubbleView {
public:
- PermissionBubbleViewViews(views::View* anchor_view,
- const std::string& languages);
+ explicit PermissionBubbleViewViews(const std::string& languages);
~PermissionBubbleViewViews() override;
+ // Must be called before |Show| at least once.
+ void SetAnchor(views::View* view, views::BubbleBorder::Arrow arrow);
+
// PermissionBubbleView:
void SetDelegate(Delegate* delegate) override;
void Show(const std::vector<PermissionBubbleRequest*>& requests,
@@ -38,6 +41,7 @@ class PermissionBubbleViewViews : public PermissionBubbleView {
private:
views::View* anchor_view_;
+ views::BubbleBorder::Arrow anchor_arrow_;
Delegate* delegate_;
PermissionsBubbleDelegateView* bubble_delegate_;
const std::string languages_;

Powered by Google App Engine
This is Rietveld 408576698