Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 962453002: Update permission bubble anchor when omnibar is hidden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comment and don't CHECK(anchor_view) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 // the bubble once and re-use it for the life of the browser, but certain 118 // the bubble once and re-use it for the life of the browser, but certain
119 // events (such as changing enabling/disabling Aero on Win) can force a need 119 // events (such as changing enabling/disabling Aero on Win) can force a need
120 // to change some of the bubble's creation parameters. 120 // to change some of the bubble's creation parameters.
121 void InitStatusBubble(); 121 void InitStatusBubble();
122 122
123 // Initializes the permission bubble view. This class is intended to be 123 // Initializes the permission bubble view. This class is intended to be
124 // created once and then re-used for the life of the browser window. The 124 // created once and then re-used for the life of the browser window. The
125 // bubbles it creates will be associated with a single visible tab. 125 // bubbles it creates will be associated with a single visible tab.
126 void InitPermissionBubbleView(); 126 void InitPermissionBubbleView();
127 127
128 // Updates the permission bubble view's anchor. It's necessary to update the
129 // bubble view so that it is in the correct location the next time it needs to
130 // be shown.
131 void UpdatePermissionBubbleView();
felt 2015/03/03 01:04:35 Should this be renamed something more literal, lik
hcarmona 2015/03/06 23:24:16 Done.
132
128 // Returns the apparent bounds of the toolbar, in BrowserView coordinates. 133 // Returns the apparent bounds of the toolbar, in BrowserView coordinates.
129 // These differ from |toolbar_.bounds()| in that they match where the toolbar 134 // These differ from |toolbar_.bounds()| in that they match where the toolbar
130 // background image is drawn -- slightly outside the "true" bounds 135 // background image is drawn -- slightly outside the "true" bounds
131 // horizontally. Note that this returns the bounds for the toolbar area. 136 // horizontally. Note that this returns the bounds for the toolbar area.
132 gfx::Rect GetToolbarBounds() const; 137 gfx::Rect GetToolbarBounds() const;
133 138
134 // Returns the constraining bounding box that should be used to lay out the 139 // Returns the constraining bounding box that should be used to lay out the
135 // FindBar within. This is _not_ the size of the find bar, just the bounding 140 // FindBar within. This is _not_ the size of the find bar, just the bounding
136 // box it should be laid out within. The coordinate system of the returned 141 // box it should be laid out within. The coordinate system of the returned
137 // rect is in the coordinate system of the frame, since the FindBar is a child 142 // rect is in the coordinate system of the frame, since the FindBar is a child
(...skipping 560 matching lines...) Expand 10 before | Expand all | Expand 10 after
698 scoped_ptr<ImmersiveModeController> immersive_mode_controller_; 703 scoped_ptr<ImmersiveModeController> immersive_mode_controller_;
699 704
700 scoped_ptr<WebContentsCloseHandler> web_contents_close_handler_; 705 scoped_ptr<WebContentsCloseHandler> web_contents_close_handler_;
701 706
702 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_; 707 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_;
703 708
704 DISALLOW_COPY_AND_ASSIGN(BrowserView); 709 DISALLOW_COPY_AND_ASSIGN(BrowserView);
705 }; 710 };
706 711
707 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 712 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698