Update permission bubble anchor when omnibar is hidden

chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/website_settings/permissions_bubble_view.h"
 
 #include "base/strings/string16.h"
 #include "chrome/browser/ui/views/website_settings/permission_selector_view.h"
 #include "chrome/browser/ui/views/website_settings/permission_selector_view_observer.h"
 #include "chrome/browser/ui/website_settings/permission_bubble_request.h"
@@ skipping 122 matching lines @@
       index_, permission.setting == CONTENT_SETTING_ALLOW);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // View implementation for the permissions bubble.
 class PermissionsBubbleDelegateView : public views::BubbleDelegateView,
                                       public views::ButtonListener,
                                       public PermissionCombobox::Listener {
  public:
   PermissionsBubbleDelegateView(
-      views::View* anchor,
+      views::View* anchor_view,
+      views::BubbleBorder::Arrow anchor_arrow,
       PermissionBubbleViewViews* owner,
       const std::string& languages,
       const std::vector<PermissionBubbleRequest*>& requests,
       const std::vector<bool>& accept_state);
   ~PermissionsBubbleDelegateView() override;
 
   void Close();
   void SizeToContents();
 
   // BubbleDelegateView:
@@ skipping 15 matching lines @@
   views::Button* deny_;
   views::Combobox* allow_combobox_;
   base::string16 hostname_;
   scoped_ptr<PermissionMenuModel> menu_button_model_;
   std::vector<PermissionCombobox*> customize_comboboxes_;
 
   DISALLOW_COPY_AND_ASSIGN(PermissionsBubbleDelegateView);
 };
 
 PermissionsBubbleDelegateView::PermissionsBubbleDelegateView(
-    views::View* anchor,
+    views::View* anchor_view,
+    views::BubbleBorder::Arrow anchor_arrow,
     PermissionBubbleViewViews* owner,
     const std::string& languages,
     const std::vector<PermissionBubbleRequest*>& requests,
     const std::vector<bool>& accept_state)
-    : views::BubbleDelegateView(anchor, views::BubbleBorder::TOP_LEFT),
+    : views::BubbleDelegateView(anchor_view, anchor_arrow),
       owner_(owner),
       allow_(NULL),
       deny_(NULL),
       allow_combobox_(NULL) {
   DCHECK(!requests.empty());
 
   RemoveAllChildViews(true);
   customize_comboboxes_.clear();
   set_close_on_esc(true);
   set_close_on_deactivate(false);
@@ skipping 151 matching lines @@
 
 void PermissionsBubbleDelegateView::PermissionSelectionChanged(
     int index, bool allowed) {
   owner_->Toggle(index, allowed);
 }
 
 //////////////////////////////////////////////////////////////////////////////
 // PermissionBubbleViewViews
 
 PermissionBubbleViewViews::PermissionBubbleViewViews(
-    views::View* anchor_view,
     const std::string& languages)
-    : anchor_view_(anchor_view),
+    : anchor_view_(NULL),
+      anchor_arrow_(views::BubbleBorder::NONE),
       delegate_(NULL),
       bubble_delegate_(NULL),
       languages_(languages) {}
 
 PermissionBubbleViewViews::~PermissionBubbleViewViews() {
   if (delegate_)
     delegate_->SetView(NULL);
 }
 
+void PermissionBubbleViewViews::SetAnchor(
+    views::View* view,
+    views::BubbleBorder::Arrow arrow) {
+  anchor_view_ = view;

[groby-ooo-7-16, 2015/02/28 00:25:12]

This seems not right. doesn't the BubbleDelegateView already know the arrow?
(And anchor, for that matter?)

Why are we duplicating this data?

[hcarmona, 2015/02/28 01:14:16]

The BubbleDelegateView is created each time that |Show| is called, so we need to
preserve the anchor/arrow.

It's necessary to update the values since the PermissionBubbleViewViews can live
through a fullscreen toggle.

+  anchor_arrow_ = arrow;
+}
+
 void PermissionBubbleViewViews::SetDelegate(Delegate* delegate) {
   delegate_ = delegate;
 }
 
 void PermissionBubbleViewViews::Show(
     const std::vector<PermissionBubbleRequest*>& requests,
     const std::vector<bool>& values) {
   if (bubble_delegate_ != NULL)
     bubble_delegate_->Close();
 
+  CHECK(anchor_view_);

[groby-ooo-7-16, 2015/02/28 00:25:12]

Really? CHECK? We want this to crash instead of displaying the bubble in the
wrong place?

[hcarmona, 2015/02/28 01:14:16]

No, crash would be worse than displaying the bubble in the wrong place. What
does it mean for a bubble to not have an anchor? Can that happen?

+
   bubble_delegate_ =
-      new PermissionsBubbleDelegateView(anchor_view_, this, languages_,
-                                        requests, values);
+      new PermissionsBubbleDelegateView(anchor_view_, anchor_arrow_, this,
+                                        languages_, requests, values);
   views::BubbleDelegateView::CreateBubble(bubble_delegate_)->Show();
   bubble_delegate_->SizeToContents();
 }
 
 bool PermissionBubbleViewViews::CanAcceptRequestUpdate() {
   return !(bubble_delegate_ && bubble_delegate_->IsMouseHovered());
 }
 
 void PermissionBubbleViewViews::Hide() {
   if (bubble_delegate_) {
@@ skipping 20 matching lines @@
 
 void PermissionBubbleViewViews::Accept() {
   if (delegate_)
     delegate_->Accept();
 }
 
 void PermissionBubbleViewViews::Deny() {
   if (delegate_)
     delegate_->Deny();
 }