Update permission bubble anchor when omnibar is hidden

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 522 matching lines @@
 BrowserView* BrowserView::GetBrowserViewForBrowser(const Browser* browser) {
   return static_cast<BrowserView*>(browser->window());
 }
 
 void BrowserView::InitStatusBubble() {
   status_bubble_.reset(new StatusBubbleViews(contents_web_view_));
   contents_web_view_->SetStatusBubble(status_bubble_.get());
 }
 
 void BrowserView::InitPermissionBubbleView() {
-  std::string languages =
-      browser_->profile()->GetPrefs()->GetString(prefs::kAcceptLanguages);
   permission_bubble_view_.reset(new PermissionBubbleViewViews(

[groby-ooo-7-16, 2015/02/28 00:25:12]

I'm still not sure why we need to pre-create |permission_bubble_view_|. I
suppose that's a different question, but I'd like to figure it out.

[hcarmona, 2015/02/28 01:14:16]

We can probably update the code to create it only when it's needed and reuse it
if it needs to be shown again.

-      GetLocationBarView()->location_icon_view(), languages));
+      browser_->profile()->GetPrefs()->GetString(prefs::kAcceptLanguages)));
+  UpdatePermissionBubbleView();
+}
+
+void BrowserView::UpdatePermissionBubbleView() {
+  if (browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR)) {
+    permission_bubble_view_->SetAnchor(
+        GetLocationBarView()->location_icon_view(),
+        views::BubbleBorder::TOP_LEFT);
+  } else {
+    permission_bubble_view_->SetAnchor(
+        top_container_,
+        views::BubbleBorder::NONE);
+  }
 }
 
 gfx::Rect BrowserView::GetToolbarBounds() const {
   gfx::Rect toolbar_bounds(toolbar_->bounds());
   if (toolbar_bounds.IsEmpty())
     return toolbar_bounds;
   // The apparent toolbar edges are outside the "real" toolbar edges.
   toolbar_bounds.Inset(-views::NonClientFrameView::kClientEdgeThickness, 0);
   return toolbar_bounds;
 }
@@ skipping 1727 matching lines @@
   }
 
   // Undo our anti-jankiness hacks and force a re-layout. We also need to
   // recompute the height of the infobar top arrow because toggling in and out
   // of fullscreen changes it. Calling ToolbarSizeChanged() will do both these
   // things since it computes the arrow height directly and forces a layout
   // indirectly via UpdateUIForContents(). Reset |in_process_fullscreen_| in
   // order to let the layout occur.
   in_process_fullscreen_ = false;
   ToolbarSizeChanged(false);
+
+  UpdatePermissionBubbleView();

[groby-ooo-7-16, 2015/02/28 00:25:12]

Doesn't fullscreen mode imply a focus change, and so this undoes the bubble
anyways?

[hcarmona, 2015/02/28 01:14:16]

The permission bubbles remain visible even when focus changes.

This change is intended to update the anchor for the next time a bubble is shown
and doesn't affect the current bubble.

Should this re-position the current bubble? Should we hide the permissions
bubbles when they lose focus?

[felt, 2015/03/03 01:04:35]

No, we should not hide or move the permission bubbles when they lose focus.

 }
 
 bool BrowserView::ShouldUseImmersiveFullscreenForUrl(const GURL& url) const {
   // Kiosk mode needs the whole screen, and if we're not in an Ash desktop
   // immersive fullscreen doesn't exist.
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kKioskMode) ||
       browser()->host_desktop_type() != chrome::HOST_DESKTOP_TYPE_ASH) {
     return false;
   }
 
@@ skipping 257 matching lines @@
       !GetLocationBar()->GetOmniboxView()->model()->popup_model()->IsOpen()) {
     gfx::Point icon_bottom(
         toolbar_->location_bar()->GetLocationBarAnchorPoint());
     ConvertPointToTarget(toolbar_->location_bar(), this, &icon_bottom);
     gfx::Point infobar_top(0, infobar_container_->GetVerticalOverlap(nullptr));
     ConvertPointToTarget(infobar_container_, this, &infobar_top);
     top_arrow_height = infobar_top.y() - icon_bottom.y();
   }
   return top_arrow_height;
 }