Update permission bubble anchor when omnibar is hidden

chrome/browser/ui/views/website_settings/permissions_bubble_view.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_PERMISSIONS_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_PERMISSIONS_BUBBLE_VIEW_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
+#include "chrome/browser/ui/browser.h"

[msw, 2015/03/17 21:13:15]

nit: forward declare Browser for this header, include this in the cc.

[hcarmona, 2015/03/18 18:00:05]

Done.

+#include "chrome/browser/ui/views/frame/browser_view.h"

[msw, 2015/03/17 21:13:15]

nit: forward declare BrowserView for this header, include this in the cc.

[hcarmona, 2015/03/18 18:00:05]

Forward declaration no longer needed.

 #include "chrome/browser/ui/website_settings/permission_bubble_view.h"
+#include "ui/views/bubble/bubble_border.h"
 
 namespace views {
 class View;
 }
 
 class PermissionsBubbleDelegateView;
 
 class PermissionBubbleViewViews : public PermissionBubbleView {
  public:
-  PermissionBubbleViewViews(views::View* anchor_view,
-                            const std::string& languages);
+  explicit PermissionBubbleViewViews(Browser* browser,

[msw, 2015/03/17 21:13:15]

The explicit keyword is only needed for constructors with one parameter, but you
will need it here if you remove the BrowserView* parameter as I suggest.

[hcarmona, 2015/03/18 18:00:05]

Done.

+                                     BrowserView* browser_view);
   ~PermissionBubbleViewViews() override;
 
+  views::View* GetAnchorView();

[msw, 2015/03/17 21:13:15]

These three functions should be private, since they're not used externally.

[hcarmona, 2015/03/18 18:00:05]

Done.

+  views::BubbleBorder::Arrow GetAnchorArrow();
+  void UpdateAnchorPosition();
+
   // PermissionBubbleView:
   void SetDelegate(Delegate* delegate) override;
   void Show(const std::vector<PermissionBubbleRequest*>& requests,
             const std::vector<bool>& accept_state) override;
   bool CanAcceptRequestUpdate() override;
   void Hide() override;
   bool IsVisible() override;
 
   void Closing();
   void Toggle(int index, bool value);
   void Accept();
   void Deny();
 
  private:
-  views::View* anchor_view_;
+  Browser* browser_;
+  BrowserView* browser_view_;
   Delegate* delegate_;
   PermissionsBubbleDelegateView* bubble_delegate_;
   const std::string languages_;
 
   DISALLOW_COPY_AND_ASSIGN(PermissionBubbleViewViews);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_PERMISSIONS_BUBBLE_VIEW_H_