Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 962453002: Update permission bubble anchor when omnibar is hidden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply Feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 120
121 // Initializes (or re-initializes) the status bubble. We try to only create 121 // Initializes (or re-initializes) the status bubble. We try to only create
122 // the bubble once and re-use it for the life of the browser, but certain 122 // the bubble once and re-use it for the life of the browser, but certain
123 // events (such as changing enabling/disabling Aero on Win) can force a need 123 // events (such as changing enabling/disabling Aero on Win) can force a need
124 // to change some of the bubble's creation parameters. 124 // to change some of the bubble's creation parameters.
125 void InitStatusBubble(); 125 void InitStatusBubble();
126 126
127 // Initializes the permission bubble view. This class is intended to be 127 // Initializes the permission bubble view. This class is intended to be
128 // created once and then re-used for the life of the browser window. The 128 // created once and then re-used for the life of the browser window. The
129 // bubbles it creates will be associated with a single visible tab. 129 // bubbles it creates will be associated with a single visible tab.
130 void InitPermissionBubbleView(); 130 void InitPermissionBubbleView();
msw 2015/03/12 20:44:05 We should probably remove InitPermissionBubbleView
hcarmona 2015/03/17 01:29:27 Done.
131 131
132 // It's necessary to update the bubble view so that it is in the correct
133 // location the next time it needs to be shown.
134 void UpdatePermissionBubbleViewAnchor();
135
132 // Returns the apparent bounds of the toolbar, in BrowserView coordinates. 136 // Returns the apparent bounds of the toolbar, in BrowserView coordinates.
133 // These differ from |toolbar_.bounds()| in that they match where the toolbar 137 // These differ from |toolbar_.bounds()| in that they match where the toolbar
134 // background image is drawn -- slightly outside the "true" bounds 138 // background image is drawn -- slightly outside the "true" bounds
135 // horizontally. Note that this returns the bounds for the toolbar area. 139 // horizontally. Note that this returns the bounds for the toolbar area.
136 gfx::Rect GetToolbarBounds() const; 140 gfx::Rect GetToolbarBounds() const;
137 141
138 // Returns the constraining bounding box that should be used to lay out the 142 // Returns the constraining bounding box that should be used to lay out the
139 // FindBar within. This is _not_ the size of the find bar, just the bounding 143 // FindBar within. This is _not_ the size of the find bar, just the bounding
140 // box it should be laid out within. The coordinate system of the returned 144 // box it should be laid out within. The coordinate system of the returned
141 // rect is in the coordinate system of the frame, since the FindBar is a child 145 // rect is in the coordinate system of the frame, since the FindBar is a child
(...skipping 573 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 scoped_ptr<ImmersiveModeController> immersive_mode_controller_; 719 scoped_ptr<ImmersiveModeController> immersive_mode_controller_;
716 720
717 scoped_ptr<WebContentsCloseHandler> web_contents_close_handler_; 721 scoped_ptr<WebContentsCloseHandler> web_contents_close_handler_;
718 722
719 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_; 723 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_;
720 724
721 DISALLOW_COPY_AND_ASSIGN(BrowserView); 725 DISALLOW_COPY_AND_ASSIGN(BrowserView);
722 }; 726 };
723 727
724 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 728 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698