DescriptionRevert of Telemetry: Refactor inspector_websocket to create cleaner interface. (patchset #2 id:80001 of https://codereview.chromium.org/942113004/)
Reason for revert:
This possibly is causing chrome tracing data leakage: BUG=461874
Original issue's description:
> Telemetry: Refactor inspector_websocket to create cleaner interface.
>
> This CL contains several improvements which are tightly coupled.
> - The method DispatchNotificationsUntilDone is only used by tracing_backend. I
> moved all the logic into tracing_backend. This has several side effects:
> - The exception DispatchNotificationsUntilDone is no longer needed.
> - The method _Receive no longer handles exceptions. It used to handle some,
> but not all exceptions. This change is very important for sane exception
> handling of the Chrome/Telemetry bindings.
> - The method _HandleNotification never has a return value. It used to
> sometimes return a boolean, and sometimes return nothing.
> - I removed the member _error_handler. This member was only used in two
> places: inspector_backend and tracing_backend. Of these two places,
> tracing_backend only used it to emit a not-so-useful log statement.
> - The biggest problem with _error_handler is that it decouples the exception
> handling from the context of the try/catch loop that triggered the
> exception.
> - The _error_handler only was called during _Receive(). This is very
> confusing, since that is not the only method that raises Exceptions. So some
> exceptions get handled by _error_handler, and some do not. :(
> - I removed all exception handling from inspector_page.py and
> inspector_websocket.py. It used to be that some exceptions would be handled in
> inspector_websocket, some would trickle up to inspector_page, and some would
> trickle out past inspector_backend.py. The eventual goal is for
> inspector_backend to catch all exceptions and translate them into
> {Recoverable/Unrecoverable}Exceptions.
>
> BUG=460625
>
> Committed: https://crrev.com/64cf2ab4a6a348954d46d9d758c5be53aa1c1220
> Cr-Commit-Position: refs/heads/master@{#317972}
TBR=sullivan@chromium.org,slamm@chromium.org,erikchen@chromium.org
BUG=460625
Committed: https://crrev.com/179e300754aeda5ffeae3ed165324b2913487dd5
Cr-Commit-Position: refs/heads/master@{#318205}
Patch Set 1 #
Created: 5 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 7 (2 generated)
|