Add TestWebContentsFactory to content/public/test

Add TestWebContentsFactory to content/public/test

TestWebContentsFactory is a class that can create WebContents for unittests,
but can be created on the stack. This gives it the advantage of being able to
be used in tests that are already inheriting from something other than
RenderViewTestHarness.

Committed: https://crrev.com/c351e82b9e7a5ca9cfe9135db88f5afa035f64b7
Cr-Commit-Position: refs/heads/master@{#318740}

[Devlin, 2015-02-27 23:15:50]

rdevlin.cronin@chromium.org changed reviewers:
+ sky@chromium.org

[Devlin, 2015-02-27 23:15:50]

Scott, mind taking a look?

[sky, 2015-02-28 17:30:46]

https://codereview.chromium.org/962393002/diff/1/content/public/test/test_web...
File content/public/test/test_web_contents_factory.h (right):

https://codereview.chromium.org/962393002/diff/1/content/public/test/test_web...
content/public/test/test_web_contents_factory.h:33: // Creates a new WebContents
with the given |context|, and returns it.
Even though you say it in the class descriptions I would clearly say here the
returned WebContents is owned by TestWebContentsFactory.

https://codereview.chromium.org/962393002/diff/1/content/test/test_web_conten...
File content/test/test_web_contents_factory.cc (right):

https://codereview.chromium.org/962393002/diff/1/content/test/test_web_conten...
content/test/test_web_contents_factory.cc:30: web_contents_.clear();
Document why you need to explicitly clear here.

https://codereview.chromium.org/962393002/diff/1/ui/aura/env.h
File ui/aura/env.h (right):

https://codereview.chromium.org/962393002/diff/1/ui/aura/env.h#newcode41
ui/aura/env.h:41: static bool HasInstanceForTesting();
I would rather have a GetInstanceDontCreate type of function.

[Devlin, 2015-03-02 17:23:05]

Patchset #2 (id:20001) has been deleted

[Devlin, 2015-03-02 17:27:12]

https://codereview.chromium.org/962393002/diff/1/content/public/test/test_web...
File content/public/test/test_web_contents_factory.h (right):

https://codereview.chromium.org/962393002/diff/1/content/public/test/test_web...
content/public/test/test_web_contents_factory.h:33: // Creates a new WebContents
with the given |context|, and returns it.
On 2015/02/28 17:30:45, sky wrote:
> Even though you say it in the class descriptions I would clearly say here the
> returned WebContents is owned by TestWebContentsFactory.

Done.

https://codereview.chromium.org/962393002/diff/1/content/test/test_web_conten...
File content/test/test_web_contents_factory.cc (right):

https://codereview.chromium.org/962393002/diff/1/content/test/test_web_conten...
content/test/test_web_contents_factory.cc:30: web_contents_.clear();
On 2015/02/28 17:30:45, sky wrote:
> Document why you need to explicitly clear here.

Done.

https://codereview.chromium.org/962393002/diff/1/ui/aura/env.h
File ui/aura/env.h (right):

https://codereview.chromium.org/962393002/diff/1/ui/aura/env.h#newcode41
ui/aura/env.h:41: static bool HasInstanceForTesting();
On 2015/02/28 17:30:46, sky wrote:
> I would rather have a GetInstanceDontCreate type of function.

Done.

[sky, 2015-03-02 18:12:47]

LGTM

[Devlin, 2015-03-02 18:15:43]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-03-02 18:16:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/962393002/40001

[commit-bot: I haz the power, 2015-03-02 19:57:42]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-03-02 19:59:13]

Patchset 2 (id:??) landed as
https://crrev.com/c351e82b9e7a5ca9cfe9135db88f5afa035f64b7
Cr-Commit-Position: refs/heads/master@{#318740}