Issue 962383003: Make shake-to-reload actually work

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 962383003: Make shake-to-reload actually work (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make shake-to-reload actually work We need to create a new service provider when we navigate to a new page otherwise the new page is sad that the old page took its service provider. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b17b93619475897d1d46a12fca8aa2f2c55edf6e

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -21 lines)			Patch
M	sky/examples/touch-demo.sky	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/framework/debug/shake-to-reload.sky	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/shell/java_service_provider.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sky/shell/java_service_provider.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	sky/shell/org/domokit/sky/shell/JavaServiceProvider.java	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	sky/shell/shell.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/shell/ui/engine.h	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	sky/shell/ui/engine.cc	View	4 chunks	+15 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 9 months ago (2015-02-28 00:38:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b17b93619475897d1d46a12fca8aa2f2c55edf6e (presubmit successful).