Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 962363002: fix cc_unittests gcc build (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore
Modified:
5 years, 9 months ago
Reviewers:
danakj, awoloszyn
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix cc_unittests gcc build Avoid -Wparentheses errors in gcc builds. Followup to https://codereview.chromium.org/595593002 BUG=159225

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cc/output/renderer_pixeltest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mostyn Bramley-Moore
@danakj: can you PTAL at this tiny fixup? Without this, gcc builds fail with errors ...
5 years, 9 months ago (2015-02-27 21:28:16 UTC) #2
danakj
LGTM
5 years, 9 months ago (2015-02-27 21:36:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962363002/1
5 years, 9 months ago (2015-02-27 21:39:39 UTC) #5
Mostyn Bramley-Moore
Un-queued this, since https://codereview.chromium.org/960893004 reverted the original change. @awoloszyn: can you roll this fixup into ...
5 years, 9 months ago (2015-02-27 22:28:26 UTC) #7
awoloszyn
5 years, 9 months ago (2015-02-27 22:37:13 UTC) #8
On 2015/02/27 22:28:26, Mostyn Bramley-Moore wrote:
> Un-queued this, since https://codereview.chromium.org/960893004 reverted the
> original change.
> 
> @awoloszyn: can you roll this fixup into your branch (which I assume you will
> re-submit)?

Will do sorry about the churn.

Powered by Google App Engine
This is Rietveld 408576698