Upstream UmaSessionStats.

Upstream UmaSessionStats.

UmaSessionStats is primarily for tracking metrics pertaining to the
length of a user-session in chrome (from start/resume to pause) but
also tracks some usage during the session.

BUG=428903
Committed: https://crrev.com/b71e1fa93348c4d4bc7edd76082be8d9261005ed
Cr-Commit-Position: refs/heads/master@{#318700}

[Yaron, 2015-02-27 18:41:45]

yfriedman@chromium.org changed reviewers:
+ asvitkine@chromium.org, dfalcantara@chromium.org

[Yaron, 2015-02-27 18:41:45]

dfalcantara: This is a straight upstream after the last few clean-ups
downstream.
asvitkine: histograms.xml change which was copied from the internal version

[Alexei Svitkine (slow), 2015-02-27 18:59:57]

Woot, super psyched to see this happen!

https://codereview.chromium.org/962293002/diff/1/chrome/browser/android/uma_s...
File chrome/browser/android/uma_session_stats.cc (right):

https://codereview.chromium.org/962293002/diff/1/chrome/browser/android/uma_s...
chrome/browser/android/uma_session_stats.cc:5: #include
"chrome/browser/android/uma_session_stats.h"
Could this be placed in chrome/browser/metrics/android?

Although, I see it's being put next to existing uma_* files that were
upstreamed. I think all of those should be in chrome/browser/metrics/android

Or if it makes things easier, into chrome/browser/android/metrics (with a new
OWNERS file there).

https://codereview.chromium.org/962293002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/962293002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:33385: +<histogram
name="Session.TotalDuration" units="milliseconds">
Please also send an internal CL to remove this from the other file.

[Yaron, 2015-02-27 19:13:34]

https://codereview.chromium.org/962293002/diff/1/chrome/browser/android/uma_s...
File chrome/browser/android/uma_session_stats.cc (right):

https://codereview.chromium.org/962293002/diff/1/chrome/browser/android/uma_s...
chrome/browser/android/uma_session_stats.cc:5: #include
"chrome/browser/android/uma_session_stats.h"
On 2015/02/27 18:59:57, Alexei Svitkine wrote:
> Could this be placed in chrome/browser/metrics/android?
> 
> Although, I see it's being put next to existing uma_* files that were
> upstreamed. I think all of those should be in chrome/browser/metrics/android
> 
> Or if it makes things easier, into chrome/browser/android/metrics (with a new
> OWNERS file there).

I think chrome/browser/android/metrics is a bit easier. Moved there and seeded
with a reasonable OWNERS list (you, Dan and Maria). I'm just the messenger
brining this up :)

https://codereview.chromium.org/962293002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/962293002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:33385: +<histogram
name="Session.TotalDuration" units="milliseconds">
On 2015/02/27 18:59:57, Alexei Svitkine wrote:
> Please also send an internal CL to remove this from the other file.

on it

[Maria, 2015-02-27 19:29:49]

mariakhomenko@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[Maria, 2015-02-27 19:29:50]

lgtm

Yay!

[Alexei Svitkine (slow), 2015-02-27 19:35:02]

LGTM on assumption that the code is moved as-is from the internal repo. Thanks!

Would be good to move the other couple of uma_* files to the new directory as
well.

[gone, 2015-02-27 20:23:13]

lgtm

[Yaron, 2015-03-02 14:33:51]

The CQ bit was checked by yfriedman@chromium.org

[commit-bot: I haz the power, 2015-03-02 14:34:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/962293002/40001

[Yaron, 2015-03-02 14:34:08]

On 2015/02/27 19:35:02, Alexei Svitkine wrote:
> LGTM on assumption that the code is moved as-is from the internal repo.
Thanks!
> 
> Would be good to move the other couple of uma_* files to the new directory as
> well.

I'll move the other files in a follow-up

[commit-bot: I haz the power, 2015-03-02 15:55:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-02 15:56:15]

Patchset 3 (id:??) landed as
https://crrev.com/b71e1fa93348c4d4bc7edd76082be8d9261005ed
Cr-Commit-Position: refs/heads/master@{#318700}