Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 962213003: fix analysis messages (Closed)

Created:
5 years, 9 months ago by Jennifer Messerly
Modified:
5 years, 9 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix analysis messages seen on the latest dev channel editor w/ analysis server R=sigmund@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/21aeeecf45d515e6b1cec6e96b28b76fc024ae16

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -25 lines) Patch
M lib/runtime/dart_runtime.dart View 1 2 chunks +2 lines, -16 lines 0 comments Download
M lib/src/testing.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M test/checker/inferred_type_test.dart View 1 chunk +0 lines, -1 line 1 comment Download
M test/codegen/dir/html_input_c.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M test/codegen/dom.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M test/codegen/fieldtest.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/patch_sdk.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
https://codereview.chromium.org/962213003/diff/20001/test/checker/inferred_type_test.dart File test/checker/inferred_type_test.dart (left): https://codereview.chromium.org/962213003/diff/20001/test/checker/inferred_type_test.dart#oldcode382 test/checker/inferred_type_test.dart:382: '/e2.dart': '', duplicate map keys (it's defined below) https://codereview.chromium.org/962213003/diff/20001/test/codegen/dir/html_input_c.dart ...
5 years, 9 months ago (2015-02-27 16:53:33 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/962213003/diff/20001/lib/runtime/dart_runtime.dart File lib/runtime/dart_runtime.dart (right): https://codereview.chromium.org/962213003/diff/20001/lib/runtime/dart_runtime.dart#newcode131 lib/runtime/dart_runtime.dart:131: bool _isFunctionSubTypeHelper(TypeMirror ret1, List<ParameterMirror> params1, on second thought, I ...
5 years, 9 months ago (2015-02-27 16:54:13 UTC) #4
Siggi Cherem (dart-lang)
lgtm with the small change below https://codereview.chromium.org/962213003/diff/40001/test/checker/inferred_type_test.dart File test/checker/inferred_type_test.dart (left): https://codereview.chromium.org/962213003/diff/40001/test/checker/inferred_type_test.dart#oldcode382 test/checker/inferred_type_test.dart:382: '/e2.dart': '', revert?
5 years, 9 months ago (2015-02-27 17:05:05 UTC) #5
Jennifer Messerly
5 years, 9 months ago (2015-02-27 17:06:17 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
21aeeecf45d515e6b1cec6e96b28b76fc024ae16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698