Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 962163002: Add [TypeChecking=Unrestricted] to MIDIMessageEventInit (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add [TypeChecking=Unrestricted] to MIDIMessageEventInit This will cause a TypeError to be thrown if 'receivedTime' is non-finite, as is required (indirectly, by referencing Web IDL) by the specification. BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/modules/webmidi/MIDIMessageEventInit.idl View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Jens Widell
PTAL
5 years, 9 months ago (2015-02-27 11:07:43 UTC) #2
Takashi Toyoshima
+kouhei who may know better on Web IDL than me. I don't understand the background ...
5 years, 9 months ago (2015-02-27 11:58:21 UTC) #4
Jens Widell
On 2015/02/27 11:58:21, Takashi Toyoshima (chromium) wrote: > +kouhei who may know better on Web ...
5 years, 9 months ago (2015-02-27 12:01:43 UTC) #5
kouhei (in TOK)
lgtm
5 years, 9 months ago (2015-02-27 14:47:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962163002/1
5 years, 9 months ago (2015-02-27 14:49:19 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 16:00:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191007

Powered by Google App Engine
This is Rietveld 408576698