Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: test/codegen/expect/_js_names/_js_names.js

Issue 962083002: support the JS builtin (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/codegen/expect/_js_helper/_js_helper.js ('k') | test/codegen/expect/_js_primitives/_js_primitives.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/codegen/expect/_js_names/_js_names.js
diff --git a/test/codegen/expect/_js_names/_js_names.js b/test/codegen/expect/_js_names/_js_names.js
index c7410d41ad27e017ec2a3d17dea54b9be66e8152..804cdd9630cc9fddf93c641b73892c9d57aadff7 100644
--- a/test/codegen/expect/_js_names/_js_names.js
+++ b/test/codegen/expect/_js_names/_js_names.js
@@ -27,7 +27,7 @@ var _js_names;
let getterPrefixLength = getterPrefix.length;
let setterPrefix = _foreign_helper.JS_GET_NAME('SETTER_PREFIX');
for (let key of keys) {
- let value = dart.as(_foreign_helper.JS('String', '#[#]', jsMangledNames, key), core.String);
+ let value = jsMangledNames[key];
result.set(key, value);
if (!dart.notNull(isGlobal)) {
if (key.startsWith(getterPrefix)) {
@@ -48,7 +48,14 @@ var _js_names;
}
// Function extractKeys: (dynamic) → List<dynamic>
function extractKeys(victim) {
- let result = _foreign_helper.JS('', '\n(function(victim, hasOwnProperty) {\n var result = [];\n for (var key in victim) {\n if (hasOwnProperty.call(victim, key)) result.push(key);\n }\n return result;\n})(#, Object.prototype.hasOwnProperty)', victim);
+ let result = function(victim, hasOwnProperty) {
+ var result = [];
+ for (var key in victim) {
+ if (hasOwnProperty.call(victim, key))
+ result.push(key);
+ }
+ return result;
+ }(victim, Object.prototype.hasOwnProperty);
return new _interceptors.JSArray.markFixed(result);
}
// Function unmangleGlobalNameIfPreservedAnyways: (String) → String
@@ -58,7 +65,9 @@ var _js_names;
}
// Function unmangleAllIdentifiersIfPreservedAnyways: (String) → String
function unmangleAllIdentifiersIfPreservedAnyways(str) {
- return dart.as(_foreign_helper.JS("String", "(#).replace(/[^<,> ]+/g," + "function(m) { return #[m] || m; })", str, _foreign_helper.JS_EMBEDDED_GLOBAL('', dart.as(_js_embedded_names.MANGLED_GLOBAL_NAMES, core.String))), core.String);
+ return str.replace(/[^<,> ]+/g, function(m) {
+ return _foreign_helper.JS_EMBEDDED_GLOBAL('', dart.as(_js_embedded_names.MANGLED_GLOBAL_NAMES, core.String))[m] || m;
+ });
}
// Exports:
_js_names.preserveNames = preserveNames;
« no previous file with comments | « test/codegen/expect/_js_helper/_js_helper.js ('k') | test/codegen/expect/_js_primitives/_js_primitives.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698