Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 962053003: tests: Use runPendingTasks instead of WebThread::enterRunLoop()/exitRunLoop() (Closed)

Created:
5 years, 9 months ago by sadrul
Modified:
5 years, 9 months ago
Reviewers:
haraken, dcheng
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

tests: Use runPendingTasks instead of WebThread::enterRunLoop()/exitRunLoop() Remove FrameTestHelper::runPendingTasks in favour of the version in core ( blink::testing::runPendingTasks()), and use that where appropriate, instead of directly using WebThread::enterRunLoop()/exitRunLoop(). BUG=462927 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191123

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -118 lines) Patch
M Source/bindings/core/v8/ScriptStreamerTest.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M Source/core/fetch/MemoryCacheTest.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/NetworkStateNotifierTest.cpp View 3 chunks +3 lines, -21 lines 0 comments Download
M Source/web/tests/AssociatedURLLoaderTest.cpp View 6 chunks +4 lines, -9 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.cpp View 4 chunks +2 lines, -27 lines 0 comments Download
M Source/web/tests/ImeOnFocusTest.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/web/tests/TextFinderTest.cpp View 8 chunks +8 lines, -6 lines 0 comments Download
M Source/web/tests/TouchActionTest.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/web/tests/ViewportTest.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 15 chunks +25 lines, -26 lines 2 comments Download
M Source/web/tests/WebHelperPluginTest.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/web/tests/WebPageNewSerializerTest.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/web/tests/WebPluginContainerTest.cpp View 6 chunks +7 lines, -5 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sadrul
5 years, 9 months ago (2015-03-01 10:18:06 UTC) #2
dcheng
They don't appear to be equivalent implementations, but it looks like all the tests pass! ...
5 years, 9 months ago (2015-03-02 14:23:59 UTC) #3
dcheng
https://codereview.chromium.org/962053003/diff/40001/Source/web/tests/WebFrameTest.cpp File Source/web/tests/WebFrameTest.cpp (right): https://codereview.chromium.org/962053003/diff/40001/Source/web/tests/WebFrameTest.cpp#newcode459 Source/web/tests/WebFrameTest.cpp:459: EXPECT_THAT(matchedSelectors(), ElementsAre("div.initial_on")); FWIW, I'd prefer to see this in ...
5 years, 9 months ago (2015-03-02 14:25:29 UTC) #4
sadrul
+haraken@ for Source/bindings/ owner review https://codereview.chromium.org/962053003/diff/40001/Source/web/tests/WebFrameTest.cpp File Source/web/tests/WebFrameTest.cpp (right): https://codereview.chromium.org/962053003/diff/40001/Source/web/tests/WebFrameTest.cpp#newcode459 Source/web/tests/WebFrameTest.cpp:459: EXPECT_THAT(matchedSelectors(), ElementsAre("div.initial_on")); On 2015/03/02 ...
5 years, 9 months ago (2015-03-02 16:01:35 UTC) #6
haraken
bindings/ LGTM.
5 years, 9 months ago (2015-03-02 16:35:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962053003/40001
5 years, 9 months ago (2015-03-02 17:03:21 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 17:52:38 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191123

Powered by Google App Engine
This is Rietveld 408576698