Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 962043002: Expose Android sensors to via Mojo services (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Expose Android sensors to via Mojo services This CL adds a sensor_service to sky/services and wires it into SkyShell The plan is to eventually use this data to implement shake-to-refresh. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a7e95fbd06265542e34449ac8e9e47f0e5ccac68

Patch Set 1 #

Patch Set 2 : context provider #

Patch Set 3 : works #

Patch Set 4 : Cleaner #

Total comments: 8

Patch Set 5 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+424 lines, -16 lines) Patch
M sky/apk/demo/AndroidManifest.xml View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/script/dart_controller.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
A sky/examples/shell/sensor.sky View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
A sky/framework/shell.dart View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java View 1 2 2 chunks +6 lines, -1 line 0 comments Download
A + sky/services/sensors/BUILD.gn View 1 chunk +11 lines, -6 lines 0 comments Download
A sky/services/sensors/org/domokit/sensors/SensorForwarder.java View 1 2 3 4 1 chunk +111 lines, -0 lines 0 comments Download
A sky/services/sensors/org/domokit/sensors/SensorServiceImpl.java View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A sky/services/sensors/sensors.mojom View 1 chunk +42 lines, -0 lines 0 comments Download
M sky/shell/BUILD.gn View 4 chunks +6 lines, -0 lines 0 comments Download
M sky/shell/java_service_provider.cc View 2 chunks +3 lines, -1 line 0 comments Download
M sky/shell/org/domokit/sky/shell/JavaServiceProvider.java View 1 2 4 chunks +14 lines, -4 lines 0 comments Download
M sky/shell/org/domokit/sky/shell/SkyApplication.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/shell/ui/engine.h View 3 chunks +4 lines, -0 lines 0 comments Download
M sky/shell/ui/engine.cc View 3 chunks +8 lines, -2 lines 0 comments Download
A sky/shell/ui/internals.h View 1 chunk +35 lines, -0 lines 0 comments Download
A sky/shell/ui/internals.cc View 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
5 years, 9 months ago (2015-02-27 19:12:57 UTC) #1
eseidel
I think we should walk this through in person. https://codereview.chromium.org/962043002/diff/60001/sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java File sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java (right): https://codereview.chromium.org/962043002/diff/60001/sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java#newcode37 sky/services/oknet/src/org/domokit/oknet/NetworkServiceImpl.java:37: ...
5 years, 9 months ago (2015-02-27 21:31:00 UTC) #3
eseidel
lgtm https://codereview.chromium.org/962043002/diff/60001/sky/examples/shell/sensor.sky File sky/examples/shell/sensor.sky (right): https://codereview.chromium.org/962043002/diff/60001/sky/examples/shell/sensor.sky#newcode6 sky/examples/shell/sensor.sky:6: int count = 0; member https://codereview.chromium.org/962043002/diff/60001/sky/examples/shell/sensor.sky#newcode37 sky/examples/shell/sensor.sky:37: <div>Hello, ...
5 years, 9 months ago (2015-02-27 22:29:26 UTC) #4
abarth-chromium
https://codereview.chromium.org/962043002/diff/60001/sky/services/sensors/org/domokit/sensors/SensorForwarder.java File sky/services/sensors/org/domokit/sensors/SensorForwarder.java (right): https://codereview.chromium.org/962043002/diff/60001/sky/services/sensors/org/domokit/sensors/SensorForwarder.java#newcode88 sky/services/sensors/org/domokit/sensors/SensorForwarder.java:88: Log.e(TAG, "No default sensor for sensor type " + ...
5 years, 9 months ago (2015-02-27 22:34:05 UTC) #5
abarth-chromium
5 years, 9 months ago (2015-02-27 22:37:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
a7e95fbd06265542e34449ac8e9e47f0e5ccac68 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698