Left align bubble title and text, adjusted spacing between.

chrome/browser/ui/views/global_error_bubble_view.cc

Index: chrome/browser/ui/views/global_error_bubble_view.cc
diff --git a/chrome/browser/ui/views/global_error_bubble_view.cc b/chrome/browser/ui/views/global_error_bubble_view.cc
index 1fae5f6ecac3155877a94062b443328ea69685e0..763482c393b30b09567ec41e1273dc3453f041c1 100644
--- a/chrome/browser/ui/views/global_error_bubble_view.cc
+++ b/chrome/browser/ui/views/global_error_bubble_view.cc
@@ -35,7 +35,10 @@ const int kMaxBubbleViewWidth = 262;
 // The vertical inset of the wrench bubble anchor from the wrench menu button.
 const int kAnchorVerticalInset = 5;
 
-const int kBubblePadding = 6;
+// Align bubble text with the title.
+const int kBubbleLeftPadding = 19;
+
+const int kBubblePadding = 11;

[msw, 2015/02/27 03:25:50]

nit: this should just be 19px or 20px and combined with the left side constant.
This will make the text spaced evenly on both sides, and the insets will match
those of a standard dialog. (in a followup, we can try to use DialogClientView)

[xiaoling, 2015/02/27 18:00:38]

Done.

 
 }  // namespace
 
@@ -106,7 +109,8 @@ GlobalErrorBubbleView::GlobalErrorBubbleView(
   SetLayoutManager(layout);
 
   // BubbleFrameView adds enough padding below title, no top padding needed.
-  layout->SetInsets(0, kBubblePadding, kBubblePadding, kBubblePadding);
+  set_margins(gfx::Insets(0, kBubbleLeftPadding,
+                          kBubblePadding, kBubblePadding));

[xiaoling, 2015/02/27 02:59:34]

I thought I have moved set_margins to the top of the function, but apparently
not or not uploaded. I'll do that tomorrow.

[msw, 2015/02/27 03:25:50]

Acknowledged.

 
   // First row, message labels.
   views::ColumnSet* cs = layout->AddColumnSet(0);