Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 961993007: Pull MessageListView into its own file for easier testing. (Closed)

Created:
5 years, 9 months ago by dewittj
Modified:
5 years, 7 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pull MessageListView into its own file for easier testing. Tests will appear in a future CL. BUG=NONE Committed: https://crrev.com/ecf17887da48e9b04a6e7db6b45a233b0c5feb2c Cr-Commit-Position: refs/heads/master@{#327308}

Patch Set 1 : Fix gn build #

Patch Set 2 : Merge with master #

Patch Set 3 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+495 lines, -444 lines) Patch
M ui/message_center/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/message_center/message_center.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/message_center/views/message_center_view.h View 1 chunk +4 lines, -10 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 3 chunks +1 line, -434 lines 0 comments Download
A ui/message_center/views/message_list_view.h View 1 2 1 chunk +103 lines, -0 lines 0 comments Download
A ui/message_center/views/message_list_view.cc View 1 2 1 chunk +383 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dewittj
No changes to actual code, just moving files.
5 years, 7 months ago (2015-04-27 23:24:52 UTC) #4
Dmitry Titov
LGTM
5 years, 7 months ago (2015-04-28 15:23:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961993007/80001
5 years, 7 months ago (2015-04-28 16:03:10 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 7 months ago (2015-04-28 17:01:13 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 17:03:44 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ecf17887da48e9b04a6e7db6b45a233b0c5feb2c
Cr-Commit-Position: refs/heads/master@{#327308}

Powered by Google App Engine
This is Rietveld 408576698