Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 961993006: [Chromecast] Remove in-memory HttpCache. (Closed)

Created:
5 years, 9 months ago by derekjchow1
Modified:
5 years, 9 months ago
Reviewers:
lcwu1
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Remove in-memory HttpCache. BUG=internal b/19212285 R=lcwu@chromium.org Committed: https://crrev.com/01a3a6167e4a510cb6c863bdedb32f0fcf344292 Cr-Commit-Position: refs/heads/master@{#318929}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chromecast/browser/url_request_context_factory.cc View 1 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
derekjchow1
5 years, 9 months ago (2015-03-03 18:47:13 UTC) #1
lcwu1
lgtm https://codereview.chromium.org/961993006/diff/1/chromecast/browser/url_request_context_factory.cc File chromecast/browser/url_request_context_factory.cc (right): https://codereview.chromium.org/961993006/diff/1/chromecast/browser/url_request_context_factory.cc#newcode368 chromecast/browser/url_request_context_factory.cc:368: protocol_handlers, request_interceptors.Pass()); nit: I would probably move request_interceptors.Pass() ...
5 years, 9 months ago (2015-03-03 19:01:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961993006/20001
5 years, 9 months ago (2015-03-03 19:06:55 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 19:40:04 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 19:40:35 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01a3a6167e4a510cb6c863bdedb32f0fcf344292
Cr-Commit-Position: refs/heads/master@{#318929}

Powered by Google App Engine
This is Rietveld 408576698