Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 961993003: Web Animations: Fix Player's timing update when source content becomes longer (Closed)

Created:
5 years, 10 months ago by dstockwell
Modified:
5 years, 9 months ago
Reviewers:
samli
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Web Animations: Fix Player's timing update when source content becomes longer A Player's hold time may become unlimited when the source content changes, special care is required to adjust the current time in this case as the existing start time should be maintained. CSS Animations required an additional fix, as the inert animation used for sampling in the same recalc that could update the timing properties of an animation, used a stale currentTime value which would be limited by the the previous timing data. BUG=461691 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191073

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -12 lines) Patch
A LayoutTests/web-animations-api/player-source-becomes-longer.html View 1 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationPlayer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 2 chunks +26 lines, -11 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
dstockwell
5 years, 10 months ago (2015-02-26 23:20:24 UTC) #2
samli
lgtm, should add a test?
5 years, 10 months ago (2015-02-27 00:49:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961993003/20001
5 years, 9 months ago (2015-03-02 00:21:44 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 02:50:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191073

Powered by Google App Engine
This is Rietveld 408576698