Rename probe/canary usages to secure proxy check.

Rename probe/canary usages to secure proxy check.

We interchangeably used probe and canary throughout the Data Reduction
Proxy component; neither is very descriptive about what is taking place.

SecureProxyCheck is sufficiently descriptive but succinct.

BUG=460299
Committed: https://crrev.com/5e18930569f8651b16dac2ce22f18f2231c39669
Cr-Commit-Position: refs/heads/master@{#318564}

[jeremyim, 2015-02-26 22:02:30]

jeremyim@chromium.org changed reviewers:
+ bengr@chromium.org

[jeremyim, 2015-02-26 22:02:31]

PTAL. =)

[bengr, 2015-02-26 22:38:43]

https://codereview.chromium.org/961983002/diff/1/components/data_reduction_pr...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
(left):

https://codereview.chromium.org/961983002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h:98:
// HandleProbeResponse should always call RecordProbeURLFetchResult exactly
You should probably only do name changes in this CL

https://codereview.chromium.org/961983002/diff/1/components/data_reduction_pr...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
(right):

https://codereview.chromium.org/961983002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc:124:
SetSecureProxyCheckResult(secure_proxy_check_url, response,
Move secure_proxy... to the next line to buy more space per line.

https://codereview.chromium.org/961983002/diff/1/components/data_reduction_pr...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
(right):

https://codereview.chromium.org/961983002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc:279:
// The proxy is disabled initially. Secure proxy checks should not be emitted
This sentence is now strange.

[jeremyim, 2015-02-26 23:08:03]

https://codereview.chromium.org/961983002/diff/1/components/data_reduction_pr...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
(left):

https://codereview.chromium.org/961983002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h:98:
// HandleProbeResponse should always call RecordProbeURLFetchResult exactly
On 2015/02/26 22:38:43, bengr wrote:
> You should probably only do name changes in this CL

Done.

https://codereview.chromium.org/961983002/diff/1/components/data_reduction_pr...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
(right):

https://codereview.chromium.org/961983002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc:124:
SetSecureProxyCheckResult(secure_proxy_check_url, response,
On 2015/02/26 22:38:43, bengr wrote:
> Move secure_proxy... to the next line to buy more space per line.

Done.

https://codereview.chromium.org/961983002/diff/1/components/data_reduction_pr...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
(right):

https://codereview.chromium.org/961983002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc:279:
// The proxy is disabled initially. Secure proxy checks should not be emitted
On 2015/02/26 22:38:43, bengr wrote:
> This sentence is now strange.

Done.

[bengr, 2015-02-27 23:57:03]

lgtm, with nit.

https://codereview.chromium.org/961983002/diff/20001/components/data_reductio...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
(right):

https://codereview.chromium.org/961983002/diff/20001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc:279:
// The proxy is disabled initially. Everything should remain disabled.
I don't understand this sentence either.

[jeremyim, 2015-02-28 00:00:40]

The CQ bit was checked by jeremyim@chromium.org

[jeremyim, 2015-02-28 00:00:41]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org
Link to the patchset: https://codereview.chromium.org/961983002/#ps40001 (title:
"Fix comment")

[jeremyim, 2015-02-28 00:01:40]

https://codereview.chromium.org/961983002/diff/20001/components/data_reductio...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
(right):

https://codereview.chromium.org/961983002/diff/20001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc:279:
// The proxy is disabled initially. Everything should remain disabled.
On 2015/02/27 23:57:03, bengr wrote:
> I don't understand this sentence either.

Done.

[commit-bot: I haz the power, 2015-02-28 00:01:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/961983002/40001

[commit-bot: I haz the power, 2015-02-28 01:32:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-28 01:33:35]

Patchset 3 (id:??) landed as
https://crrev.com/5e18930569f8651b16dac2ce22f18f2231c39669
Cr-Commit-Position: refs/heads/master@{#318564}