Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 961933003: udpate dox for colorfilter fragment processor requirements (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
bsalomon, Stephen White
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

udpate dox for colorfilter fragment processor requirements BUG=skia: NOTRY=True Committed: https://skia.googlesource.com/skia/+/b7affb56bb295d52e543d6f0e45ba45acf42dcd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M include/core/SkColorFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
reed1
5 years, 9 months ago (2015-03-04 21:09:11 UTC) #2
reed1
ptal
5 years, 9 months ago (2015-03-04 21:25:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961933003/1
5 years, 9 months ago (2015-03-04 21:26:20 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-04 21:26:20 UTC) #6
Stephen White
LGTM. Although it might be an interesting optimization to skip the remultiply/unpremultiply where possible. I ...
5 years, 9 months ago (2015-03-04 21:28:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b7affb56bb295d52e543d6f0e45ba45acf42dcd6
5 years, 9 months ago (2015-03-04 21:30:53 UTC) #8
reed1
5 years, 9 months ago (2015-03-04 22:08:43 UTC) #9
Message was sent while issue was closed.
On 2015/03/04 21:28:45, Stephen White wrote:
> LGTM.
> 
> Although it might be an interesting optimization to skip the
> remultiply/unpremultiply where possible. I guess we'd have to provide a way
for
> a frag processor to request unpremultiplied colors from the previous
processor.

Sure. If ganesh wants more flexibility when communicating pre-post requirements
in its stages, that's obviously fine by me.

Powered by Google App Engine
This is Rietveld 408576698