Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7329)

Unified Diff: chrome/installer/util/installer_state.cc

Issue 96193003: Uninstall multi-install Chrome Frame when updated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase to r237927 Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/installer_state.cc
diff --git a/chrome/installer/util/installer_state.cc b/chrome/installer/util/installer_state.cc
index 3c64a1edc7ba12833b347145a4c0d5840a071a9c..ed85dc3f20999b4de4b1779cececfb23cd38e0de 100644
--- a/chrome/installer/util/installer_state.cc
+++ b/chrome/installer/util/installer_state.cc
@@ -72,10 +72,10 @@ bool InstallerState::IsMultiInstallUpdate(const MasterPreferences& prefs,
InstallerState::InstallerState()
: operation_(UNINITIALIZED),
+ state_type_(BrowserDistribution::CHROME_BROWSER),
multi_package_distribution_(NULL),
level_(UNKNOWN_LEVEL),
package_type_(UNKNOWN_PACKAGE_TYPE),
- state_type_(BrowserDistribution::CHROME_BROWSER),
root_key_(NULL),
msi_(false),
verbose_logging_(false),
@@ -84,10 +84,10 @@ InstallerState::InstallerState()
InstallerState::InstallerState(Level level)
: operation_(UNINITIALIZED),
+ state_type_(BrowserDistribution::CHROME_BROWSER),
multi_package_distribution_(NULL),
level_(UNKNOWN_LEVEL),
package_type_(UNKNOWN_PACKAGE_TYPE),
- state_type_(BrowserDistribution::CHROME_BROWSER),
root_key_(NULL),
msi_(false),
verbose_logging_(false),
@@ -99,6 +99,8 @@ InstallerState::InstallerState(Level level)
void InstallerState::Initialize(const CommandLine& command_line,
const MasterPreferences& prefs,
const InstallationState& machine_state) {
+ Clear();
+
bool pref_bool;
if (!prefs.GetBool(master_preferences::kSystemLevel, &pref_bool))
pref_bool = false;
@@ -616,6 +618,22 @@ bool InstallerState::IsFileInUse(const base::FilePath& file) {
OPEN_EXISTING, 0, 0)).IsValid();
}
+void InstallerState::Clear() {
+ operation_ = UNINITIALIZED;
+ target_path_.clear();
+ state_key_.clear();
+ state_type_ = BrowserDistribution::CHROME_BROWSER;
+ products_.clear();
+ multi_package_distribution_ = NULL;
+ critical_update_version_ = base::Version();
+ level_ = UNKNOWN_LEVEL;
+ package_type_ = UNKNOWN_PACKAGE_TYPE;
+ root_key_ = NULL;
+ msi_ = false;
+ verbose_logging_ = false;
+ ensure_google_update_present_ = false;
+}
+
bool InstallerState::AnyExistsAndIsInUse(
const InstallationState& machine_state,
uint32 file_bits) const {

Powered by Google App Engine
This is Rietveld 408576698