Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 817 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 828 | 828 |
| 829 return [] | 829 return [] |
| 830 | 830 |
| 831 | 831 |
| 832 def _CheckSpamLogging(input_api, output_api): | 832 def _CheckSpamLogging(input_api, output_api): |
| 833 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS | 833 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS |
| 834 black_list = (_EXCLUDED_PATHS + | 834 black_list = (_EXCLUDED_PATHS + |
| 835 _TEST_CODE_EXCLUDED_PATHS + | 835 _TEST_CODE_EXCLUDED_PATHS + |
| 836 input_api.DEFAULT_BLACK_LIST + | 836 input_api.DEFAULT_BLACK_LIST + |
| 837 (r"^base[\\\/]logging\.h$", | 837 (r"^base[\\\/]logging\.h$", |
| 838 r"^remoting[\\\/]base[\\\/]logging\.h$",)) | 838 r"^remoting[\\\/]base[\\\/]logging\.h$", |
| 839 r"^chrome[\\\/]installer[\\\/]setup[\\\/].*$")) | |
|
grt (UTC plus 2)
2013/11/29 04:23:03
LOG() in Chrome's installer for Windows doesn't sp
| |
| 839 source_file_filter = lambda x: input_api.FilterSourceFile( | 840 source_file_filter = lambda x: input_api.FilterSourceFile( |
| 840 x, white_list=(file_inclusion_pattern,), black_list=black_list) | 841 x, white_list=(file_inclusion_pattern,), black_list=black_list) |
| 841 | 842 |
| 842 log_info = [] | 843 log_info = [] |
| 843 printf = [] | 844 printf = [] |
| 844 | 845 |
| 845 for f in input_api.AffectedSourceFiles(source_file_filter): | 846 for f in input_api.AffectedSourceFiles(source_file_filter): |
| 846 contents = input_api.ReadFile(f, 'rb') | 847 contents = input_api.ReadFile(f, 'rb') |
| 847 if re.search(r"\bD?LOG\s*\(\s*INFO\s*\)", contents): | 848 if re.search(r"\bD?LOG\s*\(\s*INFO\s*\)", contents): |
| 848 log_info.append(f.LocalPath()) | 849 log_info.append(f.LocalPath()) |
| (...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1112 trybots += ['cros_x86'] | 1113 trybots += ['cros_x86'] |
| 1113 | 1114 |
| 1114 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it | 1115 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it |
| 1115 # unless they're .gyp(i) files as changes to those files can break the gyp | 1116 # unless they're .gyp(i) files as changes to those files can break the gyp |
| 1116 # step on that bot. | 1117 # step on that bot. |
| 1117 if (not all(re.search('^chrome', f) for f in files) or | 1118 if (not all(re.search('^chrome', f) for f in files) or |
| 1118 any(re.search('\.gypi?$', f) for f in files)): | 1119 any(re.search('\.gypi?$', f) for f in files)): |
| 1119 trybots += ['android_aosp'] | 1120 trybots += ['android_aosp'] |
| 1120 | 1121 |
| 1121 return trybots | 1122 return trybots |
| OLD | NEW |