| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 849 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 860 return [] | 860 return [] |
| 861 | 861 |
| 862 | 862 |
| 863 def _CheckSpamLogging(input_api, output_api): | 863 def _CheckSpamLogging(input_api, output_api): |
| 864 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS | 864 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS |
| 865 black_list = (_EXCLUDED_PATHS + | 865 black_list = (_EXCLUDED_PATHS + |
| 866 _TEST_CODE_EXCLUDED_PATHS + | 866 _TEST_CODE_EXCLUDED_PATHS + |
| 867 input_api.DEFAULT_BLACK_LIST + | 867 input_api.DEFAULT_BLACK_LIST + |
| 868 (r"^base[\\\/]logging\.h$", | 868 (r"^base[\\\/]logging\.h$", |
| 869 r"^chrome[\\\/]browser[\\\/]chrome_browser_main\.cc$", | 869 r"^chrome[\\\/]browser[\\\/]chrome_browser_main\.cc$", |
| 870 r"^chrome[\\\/]installer[\\\/]setup[\\\/].*", |
| 870 r"^chrome[\\\/]renderer[\\\/]extensions[\\\/]" | 871 r"^chrome[\\\/]renderer[\\\/]extensions[\\\/]" |
| 871 r"logging_native_handler\.cc$", | 872 r"logging_native_handler\.cc$", |
| 872 r"^remoting[\\\/]base[\\\/]logging\.h$", | 873 r"^remoting[\\\/]base[\\\/]logging\.h$", |
| 873 r"^sandbox[\\\/]linux[\\\/].*",)) | 874 r"^sandbox[\\\/]linux[\\\/].*",)) |
| 874 source_file_filter = lambda x: input_api.FilterSourceFile( | 875 source_file_filter = lambda x: input_api.FilterSourceFile( |
| 875 x, white_list=(file_inclusion_pattern,), black_list=black_list) | 876 x, white_list=(file_inclusion_pattern,), black_list=black_list) |
| 876 | 877 |
| 877 log_info = [] | 878 log_info = [] |
| 878 printf = [] | 879 printf = [] |
| 879 | 880 |
| (...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1170 trybots += ['cros_x86'] | 1171 trybots += ['cros_x86'] |
| 1171 | 1172 |
| 1172 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it | 1173 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it |
| 1173 # unless they're .gyp(i) files as changes to those files can break the gyp | 1174 # unless they're .gyp(i) files as changes to those files can break the gyp |
| 1174 # step on that bot. | 1175 # step on that bot. |
| 1175 if (not all(re.search('^chrome', f) for f in files) or | 1176 if (not all(re.search('^chrome', f) for f in files) or |
| 1176 any(re.search('\.gypi?$', f) for f in files)): | 1177 any(re.search('\.gypi?$', f) for f in files)): |
| 1177 trybots += ['android_aosp'] | 1178 trybots += ['android_aosp'] |
| 1178 | 1179 |
| 1179 return trybots | 1180 return trybots |
| OLD | NEW |