Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 961863006: When deleting a profile, only call back when a new profile is created. (Closed)

Created:
5 years, 9 months ago by Bernhard Bauer
Modified:
5 years, 9 months ago
Reviewers:
Mike Lerman
CC:
chromium-reviews, rginda+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When deleting a profile, only call back when a new profile is created. Previously, the callback would be run when a new Profile object was instantiated, even when the profile already existed on disk. This would have the effect of reopening windows for closed profiles, when we just want to preload the profile on Mac. BUG=463898 Committed: https://crrev.com/ea3022ec34c38731548e3b84bee152dee44a6b3c Cr-Commit-Position: refs/heads/master@{#319607}

Patch Set 1 #

Patch Set 2 : duh #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/profiles/profile_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Bernhard Bauer
And 'nother bug. Please review :)
5 years, 9 months ago (2015-03-06 17:44:52 UTC) #2
Mike Lerman
I wonder if this bug existed before your change. Seems like it may have. Either ...
5 years, 9 months ago (2015-03-06 17:56:35 UTC) #3
Bernhard Bauer
On 2015/03/06 17:56:35, Mike Lerman wrote: > I wonder if this bug existed before your ...
5 years, 9 months ago (2015-03-09 09:43:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961863006/20001
5 years, 9 months ago (2015-03-09 09:43:35 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 10:29:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961863006/40001
5 years, 9 months ago (2015-03-09 11:15:43 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-09 12:20:36 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 12:21:13 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ea3022ec34c38731548e3b84bee152dee44a6b3c
Cr-Commit-Position: refs/heads/master@{#319607}

Powered by Google App Engine
This is Rietveld 408576698