Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 961823002: Fix issue with class name TDZ in computed property names (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
Reviewers:
rossberg, marja
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix issue with class name TDZ in computed property names BUG=v8:3923 LOG=N R=marja,rossberg Committed: https://crrev.com/392b591e0ce1507802f0b54c6672472ae41cd36c Cr-Commit-Position: refs/heads/master@{#26892}

Patch Set 1 : cleanup #

Total comments: 1

Patch Set 2 : Comment out strong test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -6 lines) Patch
M src/parser.cc View 2 chunks +1 line, -2 lines 0 comments Download
M test/mjsunit/harmony/computed-property-names.js View 1 chunk +23 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/computed-property-names-classes.js View 1 chunk +42 lines, -0 lines 0 comments Download
M test/mjsunit/strong/declaration-after-use.js View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
arv (Not doing code reviews)
rietveld!
5 years, 10 months ago (2015-02-26 16:29:21 UTC) #1
arv (Not doing code reviews)
cleanup
5 years, 10 months ago (2015-02-26 16:30:45 UTC) #2
rossberg
lgtm
5 years, 10 months ago (2015-02-26 16:32:45 UTC) #5
arv (Not doing code reviews)
Marja, this breaks the strong mode tests: /media/arv/Source/gclient-v8/v8/test/mjsunit/strong/declaration-after-use.js:183: ReferenceError: Please declare variable 'C1' before use ...
5 years, 10 months ago (2015-02-26 16:38:13 UTC) #6
rossberg
On 2015/02/26 16:38:13, arv wrote: > Marja, this breaks the strong mode tests: > > ...
5 years, 10 months ago (2015-02-26 16:46:11 UTC) #7
arv (Not doing code reviews)
Comment out strong test
5 years, 10 months ago (2015-02-26 17:53:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961823002/60001
5 years, 10 months ago (2015-02-26 18:26:31 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 10 months ago (2015-02-26 18:37:13 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 18:37:29 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/392b591e0ce1507802f0b54c6672472ae41cd36c
Cr-Commit-Position: refs/heads/master@{#26892}

Powered by Google App Engine
This is Rietveld 408576698