Fix issue with class name TDZ in computed property names

Fix issue with class name TDZ in computed property names

BUG=v8:3923
LOG=N
R=marja,rossberg

Committed: https://crrev.com/392b591e0ce1507802f0b54c6672472ae41cd36c
Cr-Commit-Position: refs/heads/master@{#26892}

[arv (Not doing code reviews), 2015-02-26 16:29:21]

rietveld!

[arv (Not doing code reviews), 2015-02-26 16:30:45]

cleanup

[arv (Not doing code reviews), 2015-02-26 16:31:03]

Patchset #1 (id:1) has been deleted

[arv (Not doing code reviews), 2015-02-26 16:31:08]

Patchset #1 (id:20001) has been deleted

[rossberg, 2015-02-26 16:32:45]

lgtm

[arv (Not doing code reviews), 2015-02-26 16:38:13]

Marja, this breaks the strong mode tests:

/media/arv/Source/gclient-v8/v8/test/mjsunit/strong/declaration-after-use.js:183:
ReferenceError: Please declare variable 'C1' before use in strong mode
  class C1 { constructor() { C1; } }; new C1();

I'm not really sure what to do about that. I think the solution we currently
have for strong mode is not going to fly here.

I'm tempted to disable the strong mode tests but I'm also not clear what
behavior we actually want for strong mode.

https://codereview.chromium.org/961823002/diff/40001/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/961823002/diff/40001/src/parser.cc#newcode4161
src/parser.cc:4161: proxy->var()->set_initializer_position(end_pos);
Marja, this was changed in
https://github.com/v8/v8-git-mirror/commit/1eddcf5b712c4a3c366a9a011e5b5b61a9....
Sorry for missing this in the review.

The name is in TDZ until after the whole class body.

[rossberg, 2015-02-26 16:46:11]

On 2015/02/26 16:38:13, arv wrote:
> Marja, this breaks the strong mode tests:
> 
>
/media/arv/Source/gclient-v8/v8/test/mjsunit/strong/declaration-after-use.js:183:
> ReferenceError: Please declare variable 'C1' before use in strong mode
>   class C1 { constructor() { C1; } }; new C1();
> 
> I'm not really sure what to do about that. I think the solution we currently
> have for strong mode is not going to fly here.
> 
> I'm tempted to disable the strong mode tests but I'm also not clear what
> behavior we actually want for strong mode.

I think it's fine to disable that test for now.

> https://codereview.chromium.org/961823002/diff/40001/src/parser.cc
> File src/parser.cc (right):
> 
> https://codereview.chromium.org/961823002/diff/40001/src/parser.cc#newcode4161
> src/parser.cc:4161: proxy->var()->set_initializer_position(end_pos);
> Marja, this was changed in
>
https://github.com/v8/v8-git-mirror/commit/1eddcf5b712c4a3c366a9a011e5b5b61a9....
> Sorry for missing this in the review.
> 
> The name is in TDZ until after the whole class body.

Ah, sorry, I missed this, too.

So this change should actually make strong mode checks for computed property
names work correctly, but instead breaks methods. But that seems natural,
methods need some special handling around this sort of class self-recursion, the
same way (mutually) recursive functions do.

[arv (Not doing code reviews), 2015-02-26 17:53:51]

Comment out strong test

[arv (Not doing code reviews), 2015-02-26 18:25:42]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2015-02-26 18:25:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/961823002/#ps60001 (title:
"Comment out strong test")

[commit-bot: I haz the power, 2015-02-26 18:26:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/961823002/60001

[commit-bot: I haz the power, 2015-02-26 18:37:13]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-02-26 18:37:29]

Patchset 2 (id:??) landed as
https://crrev.com/392b591e0ce1507802f0b54c6672472ae41cd36c
Cr-Commit-Position: refs/heads/master@{#26892}