Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 961813002: Some small code tidying (Closed)

Created:
5 years, 10 months ago by joshua.litt
Modified:
5 years, 10 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -18 lines) Patch
M src/gpu/GrClipMaskManager.cpp View 3 chunks +9 lines, -6 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +0 lines, -1 line 1 comment Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
joshualitt
5 years, 10 months ago (2015-02-26 16:25:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961813002/1
5 years, 10 months ago (2015-02-26 16:26:00 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-26 16:26:01 UTC) #5
bsalomon
https://codereview.chromium.org/961813002/diff/1/src/gpu/GrDrawTarget.h File src/gpu/GrDrawTarget.h (left): https://codereview.chromium.org/961813002/diff/1/src/gpu/GrDrawTarget.h#oldcode309 src/gpu/GrDrawTarget.h:309: AutoGeometryPush agp(this); I think this guarded against rect draws ...
5 years, 10 months ago (2015-02-26 16:45:57 UTC) #6
joshualitt
On 2015/02/26 16:45:57, bsalomon wrote: > https://codereview.chromium.org/961813002/diff/1/src/gpu/GrDrawTarget.h > File src/gpu/GrDrawTarget.h (left): > > https://codereview.chromium.org/961813002/diff/1/src/gpu/GrDrawTarget.h#oldcode309 > ...
5 years, 10 months ago (2015-02-26 16:46:18 UTC) #7
bsalomon
lgtm
5 years, 10 months ago (2015-02-26 16:47:10 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 16:47:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/642429e27c6439abff4121f0cba30a7832b4744a

Powered by Google App Engine
This is Rietveld 408576698