Issue 961773003: Retry rc50285a99bc5523ea with fix for browser test crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 961773003: Retry rc50285a99bc5523ea with fix for browser test crash (Closed)

Created:
5 years, 10 months ago by Evan Stade

Modified:
5 years, 9 months ago

Reviewers:
brettw

CC:
chromium-reviews, dbeam+watch-options_chromium.org, estade+watch_chromium.org, michaelpg+watch-options_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Retry rc50285a99bc5523ea with fix for browser test crash ---------- Show Autofill/Wallet options only when signed in. Before this patch, you could still see the options if you signed into a whitelisted account (setting the sync experiment preference) and then signed out of the account. BUG=none R=brettw@chromium.org ---------- Committed: https://crrev.com/e4f56cef9af4457ba0074e963748284d5da35165 Cr-Commit-Position: refs/heads/master@{#318573}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	chrome/browser/autofill/android/personal_data_manager_android.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/webui/options/autofill_options_handler.cc	View		2 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961773003/1

5 years, 9 months ago (2015-02-28 00:01:48 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-02-28 02:14:02 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e4f56cef9af4457ba0074e963748284d5da35165
Cr-Commit-Position: refs/heads/master@{#318573}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages