Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Unified Diff: Source/core/fetch/Resource.cpp

Issue 961773002: Add a comma delimited syntax parser and use it for Accept-CH (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/platform/CommaDelimitedParser.h » ('j') | Source/platform/CommaDelimitedParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/fetch/Resource.cpp
diff --git a/Source/core/fetch/Resource.cpp b/Source/core/fetch/Resource.cpp
index e7025397a44cebfef585efe994ab88260702c160..226c60f413163fbca364a5e1468ab618837362c5 100644
--- a/Source/core/fetch/Resource.cpp
+++ b/Source/core/fetch/Resource.cpp
@@ -35,6 +35,7 @@
#include "core/fetch/ResourcePtr.h"
#include "core/inspector/InspectorInstrumentation.h"
#include "core/loader/LinkLoader.h"
+#include "platform/CommaDelimitedParser.h"
#include "platform/Logging.h"
#include "platform/SharedBuffer.h"
#include "platform/TraceEvent.h"
@@ -445,8 +446,7 @@ void Resource::responseReceived(const ResourceResponse& response, PassOwnPtr<Web
if (fetcher && fetcher->frame()) {
LinkLoader::loadLinkFromHeader(response.httpHeaderField("Link"), fetcher->frame()->document());
if (RuntimeEnabledFeatures::clientHintsEnabled() && type() == Resource::MainResource) {
- String acceptCH = response.httpHeaderField("accept-ch").lower();
- // FIXME: Write an actual parser for this comma delimited header. crbug.com/461741
+ CommaDelimitedParser acceptCH(response.httpHeaderField("accept-ch").lower());
if (acceptCH.contains("dpr"))
fetcher->frame()->setShouldSendDPRHint();
if (acceptCH.contains("rw"))
« no previous file with comments | « no previous file | Source/platform/CommaDelimitedParser.h » ('j') | Source/platform/CommaDelimitedParser.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698