Add unittest to Open from Clipboard component.

Add unittest to Open from Clipboard component.

BUG=None.

Committed: https://crrev.com/d8262e984058e91ecb6d6d8337345a942ef07401
Cr-Commit-Position: refs/heads/master@{#319042}

[jif-google, 2015-02-26 14:43:17]

jif@google.com changed reviewers:
+ sdefresne@chromium.org

[jif-google, 2015-02-26 14:43:58]

jif@google.com changed reviewers:
+ jif@google.com

[jif-google, 2015-02-26 14:43:59]

ptal

[sdefresne, 2015-02-26 16:36:00]

https://codereview.chromium.org/961673004/diff/20001/components/open_from_cli...
File components/open_from_clipboard/clipboard_recent_content_ios.h (right):

https://codereview.chromium.org/961673004/diff/20001/components/open_from_cli...
components/open_from_clipboard/clipboard_recent_content_ios.h:14: namespace test
{
nit: blank line before

https://codereview.chromium.org/961673004/diff/20001/components/open_from_cli...
File components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm
(right):

https://codereview.chromium.org/961673004/diff/20001/components/open_from_cli...
components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm:15:
ClipboardRecentContentIOSTestHelper(){};
no ";" after {}, space before (everywhere)

https://codereview.chromium.org/961673004/diff/20001/components/open_from_cli...
components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm:22: }
}  // namespace test

https://codereview.chromium.org/961673004/diff/20001/components/open_from_cli...
components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm:35: }
}  // namespace

https://codereview.chromium.org/961673004/diff/20001/components/open_from_cli...
components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm:44:
scoped_ptr<test::ClipboardRecentContentIOSTestHelper> clipboardContent_;
The style guide is to use _clipboardContent for Objective-C(++)? classes and
clipboard_content_ for C++ classes.

[jif, 2015-03-03 14:37:59]

thanks.

https://codereview.chromium.org/961673004/diff/20001/components/open_from_cli...
File components/open_from_clipboard/clipboard_recent_content_ios.h (right):

https://codereview.chromium.org/961673004/diff/20001/components/open_from_cli...
components/open_from_clipboard/clipboard_recent_content_ios.h:14: namespace test
{
On 2015/02/26 16:36:00, sdefresne wrote:
> nit: blank line before

Done.

https://codereview.chromium.org/961673004/diff/20001/components/open_from_cli...
File components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm
(right):

https://codereview.chromium.org/961673004/diff/20001/components/open_from_cli...
components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm:15:
ClipboardRecentContentIOSTestHelper(){};
On 2015/02/26 16:36:00, sdefresne wrote:
> no ";" after {}, space before (everywhere)

Done.

https://codereview.chromium.org/961673004/diff/20001/components/open_from_cli...
components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm:22: }
On 2015/02/26 16:36:00, sdefresne wrote:
> }  // namespace test

Done.

https://codereview.chromium.org/961673004/diff/20001/components/open_from_cli...
components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm:35: }
On 2015/02/26 16:36:00, sdefresne wrote:
> }  // namespace

Done.

https://codereview.chromium.org/961673004/diff/20001/components/open_from_cli...
components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm:44:
scoped_ptr<test::ClipboardRecentContentIOSTestHelper> clipboardContent_;
On 2015/02/26 16:36:00, sdefresne wrote:
> The style guide is to use _clipboardContent for Objective-C(++)? classes and
> clipboard_content_ for C++ classes.

Done.

[sdefresne, 2015-03-03 15:54:52]

lgtm

https://codereview.chromium.org/961673004/diff/40001/components/components_te...
File components/components_tests.gyp (right):

https://codereview.chromium.org/961673004/diff/40001/components/components_te...
components/components_tests.gyp:219:
'open_from_clipboard/clipboard_recent_content_ios_unittest.mm',
nit: please move this into the OS=="ios" block below (close to the
webp_transcode/webp_decoder_unittest.mm line)

[jif, 2015-03-04 08:13:27]

The CQ bit was checked by jif@chromium.org

[jif, 2015-03-04 08:13:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/961673004/#ps90001 (title:
"Removed deliberate error.")

[commit-bot: I haz the power, 2015-03-04 08:14:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/961673004/90001

[commit-bot: I haz the power, 2015-03-04 08:35:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-04 08:35:47]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jif-google, 2015-03-04 08:43:39]

The CQ bit was checked by jif@google.com

[jif-google, 2015-03-04 08:43:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/961673004/#ps110001
(title: "Rebased.")

[jif-google, 2015-03-04 08:44:29]

The CQ bit was unchecked by jif@google.com

[jif-google, 2015-03-04 08:46:37]

Patchset #4 (id:60001) has been deleted

[jif-google, 2015-03-04 08:46:49]

Patchset #6 (id:110001) has been deleted

[jif-google, 2015-03-04 08:46:54]

Patchset #4 (id:80001) has been deleted

[jif-google, 2015-03-04 08:47:36]

Patchset #4 (id:90001) has been deleted

[jif, 2015-03-04 08:49:16]

The CQ bit was checked by jif@chromium.org

[jif, 2015-03-04 08:49:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/961673004/#ps130001
(title: "Rebased   removed bad deps.")

[commit-bot: I haz the power, 2015-03-04 08:49:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/961673004/130001

[commit-bot: I haz the power, 2015-03-04 08:53:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-04 08:53:59]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[jif, 2015-03-04 09:10:48]

The CQ bit was checked by jif@chromium.org

[jif, 2015-03-04 09:10:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/961673004/#ps150001
(title: "Add missing DEPS.")

[commit-bot: I haz the power, 2015-03-04 09:11:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/961673004/150001

[sdefresne, 2015-03-04 09:15:30]

On 2015/03/04 09:11:39, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/961673004/150001

lgtm

[commit-bot: I haz the power, 2015-03-04 09:33:16]

Committed patchset #5 (id:150001)

[commit-bot: I haz the power, 2015-03-04 09:34:16]

Patchset 5 (id:??) landed as
https://crrev.com/d8262e984058e91ecb6d6d8337345a942ef07401
Cr-Commit-Position: refs/heads/master@{#319042}