Sync the Node interface with the spec

Sync the Node interface with the spec

https://dom.spec.whatwg.org/#interface-node

The only changes to the generated code are code movement and variable
name changes.

Many types were made nullable to match the spec, as doing so did not
cause any changes to the generated code. If [TypeChecking=Interface]
were used, there would have been more differences.

BUG=460722
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190943

[philipj_slow, 2015-02-26 16:41:49]

philipj@opera.com changed reviewers:
+ haraken@chromium.org, jl@opera.com

[philipj_slow, 2015-02-26 16:41:50]

PTAL

[Jens Widell, 2015-02-26 16:47:57]

LGTM

[haraken, 2015-02-26 16:51:00]

LGTM.

> Many types were made nullable to match the spec, as doing so did not
> cause any changes to the generated code. If [TypeChecking=Interface]
> were used, there would have been more differences.

In Blink IDL, I think DOM object type is treated as nullable by default unless
we specify [TypeChecking=Interface].

We should probably fix the behavior to be comformant to the spec once we add '?'
to all DOM object types that actually need to be nullable.

[Jens Widell, 2015-02-26 16:56:28]

On 2015/02/26 16:51:00, haraken wrote:
> LGTM.
> 
> > Many types were made nullable to match the spec, as doing so did not
> > cause any changes to the generated code. If [TypeChecking=Interface]
> > were used, there would have been more differences.
> 
> In Blink IDL, I think DOM object type is treated as nullable by default unless
> we specify [TypeChecking=Interface].

Not only are the types treated as nullable by default, all values other than
correct object values are treated as null (unless [TypeChecking=Interface], that
is.)

[philipj_slow, 2015-02-26 18:09:24]

Yeah, it would be very very nice if we could make strict type checking the
default and annotate only the exceptions so that we could start removing them
one by one.

[philipj_slow, 2015-02-26 18:09:27]

Yeah, it would be very very nice if we could make strict type checking the
default and annotate only the exceptions so that we could start removing them
one by one.

[philipj_slow, 2015-02-26 18:09:32]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-02-26 18:10:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/961653004/1

[commit-bot: I haz the power, 2015-02-26 18:13:21]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190943