Issue 9616053: Fix browser_tests failure.

Issue 9616053: Fix browser_tests failure. (Closed)

Created:
8 years, 9 months ago by Yusuke Sato

Modified:
8 years, 9 months ago

Reviewers:
mazda

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix browser_tests failure. Temporarily disable the current thread CHECKs. BUG=None TEST=Patched http://codereview.chromium.org/9618022/ patchset #4, then ran browser_tests (built with "chromeos=1") with --gtest_filter='*InputMethod*' and --gtest_filter='*SystemKey*' on goobuntu. Confirmed the test passed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125367

Patch Set 1 #

Patch Set 2 : review #

Total comments: 2

Patch Set 3 : review fix #

Patch Set 4 : PTAL #

Patch Set 5 : style fix #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -8 lines)			Patch
	M	chrome/browser/chromeos/input_method/xkeyboard.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/chromeos/input_method/xkeyboard.cc	View	1 2 3	5 chunks	+21 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mazda

lgtm with a nit http://codereview.chromium.org/9616053/diff/4001/chrome/browser/chromeos/input_method/xkeyboard_unittest.cc File chrome/browser/chromeos/input_method/xkeyboard_unittest.cc (right): http://codereview.chromium.org/9616053/diff/4001/chrome/browser/chromeos/input_method/xkeyboard_unittest.cc#newcode33 chrome/browser/chromeos/input_method/xkeyboard_unittest.cc:33: #define TestSetCapsLockAndNumLockAtTheSameTime \ I prefer ...

8 years, 9 months ago (2012-03-07 05:31:19 UTC) #2

Yusuke Sato

http://codereview.chromium.org/9616053/diff/4001/chrome/browser/chromeos/input_method/xkeyboard_unittest.cc File chrome/browser/chromeos/input_method/xkeyboard_unittest.cc (right): http://codereview.chromium.org/9616053/diff/4001/chrome/browser/chromeos/input_method/xkeyboard_unittest.cc#newcode33 chrome/browser/chromeos/input_method/xkeyboard_unittest.cc:33: #define TestSetCapsLockAndNumLockAtTheSameTime \ On 2012/03/07 05:31:19, mazda wrote: > ...

8 years, 9 months ago (2012-03-07 05:43:42 UTC) #3

commit-bot: I haz the power

8 years, 9 months ago (2012-03-07 08:21:55 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/9616053/5004

Expand Messages | Collapse Messages