Adding Send to Gaia ID feature

Adding Send to Gaia ID feature

* Exposing MessageReceived as virtual on GCMDriver so that it can be
called from outside of GCMClientImpl (through IOWorker)
* Adding handling of gcmb key to GCMAccountMapper
* Adding a test for dispatching the message from GCMAccountMapper

BUG=462053
R=zea@chromium.org

Committed: https://crrev.com/47869f0c6e63a26f450809111a9847c35fed7d81
Cr-Commit-Position: refs/heads/master@{#318537}

[fgorski, 2015-02-26 00:54:49]

Hey, Nicolas, please take a look.
This handles send to gaia ID capability.

[Nicolas Zea, 2015-02-26 18:20:09]

https://codereview.chromium.org/961533002/diff/1/components/gcm_driver/gcm_dr...
File components/gcm_driver/gcm_driver.h (right):

https://codereview.chromium.org/961533002/diff/1/components/gcm_driver/gcm_dr...
components/gcm_driver/gcm_driver.h:150: virtual void MessageReceived(const
std::string& app_id,
I'm not a big fan of making this public, as it implies anyone can call it.

What about having the account mapper have a MessageRouter callback bound to this
instead, which gets invoked as needed?

[fgorski, 2015-02-27 21:17:36]

PTAL. I like this approach better too.

https://codereview.chromium.org/961533002/diff/1/components/gcm_driver/gcm_dr...
File components/gcm_driver/gcm_driver.h (right):

https://codereview.chromium.org/961533002/diff/1/components/gcm_driver/gcm_dr...
components/gcm_driver/gcm_driver.h:150: virtual void MessageReceived(const
std::string& app_id,
On 2015/02/26 18:20:09, Nicolas Zea wrote:
> I'm not a big fan of making this public, as it implies anyone can call it.
> 
> What about having the account mapper have a MessageRouter callback bound to
this
> instead, which gets invoked as needed?

Done.

[Nicolas Zea, 2015-02-27 21:33:21]

LGTM

https://codereview.chromium.org/961533002/diff/40001/components/gcm_driver/gc...
File components/gcm_driver/gcm_account_mapper.h (right):

https://codereview.chromium.org/961533002/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_account_mapper.h:110: // Callback to GCMDriver to
dispatch messages send to Gaia ID.
nit: s/send/sent

https://codereview.chromium.org/961533002/diff/40001/components/gcm_driver/gc...
File components/gcm_driver/gcm_account_mapper_unittest.cc (right):

https://codereview.chromium.org/961533002/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_account_mapper_unittest.cc:944: message.data["gcmb"] =
"test_app_id";
nit: it's a bit cleaner to declare const chars for these since you reuse them
below

[fgorski, 2015-02-27 22:12:19]

Addressed

https://codereview.chromium.org/961533002/diff/40001/components/gcm_driver/gc...
File components/gcm_driver/gcm_account_mapper.h (right):

https://codereview.chromium.org/961533002/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_account_mapper.h:110: // Callback to GCMDriver to
dispatch messages send to Gaia ID.
On 2015/02/27 21:33:21, Nicolas Zea wrote:
> nit: s/send/sent

Done.

https://codereview.chromium.org/961533002/diff/40001/components/gcm_driver/gc...
File components/gcm_driver/gcm_account_mapper_unittest.cc (right):

https://codereview.chromium.org/961533002/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_account_mapper_unittest.cc:944: message.data["gcmb"] =
"test_app_id";
On 2015/02/27 21:33:21, Nicolas Zea wrote:
> nit: it's a bit cleaner to declare const chars for these since you reuse them
> below

Done.

[fgorski, 2015-02-27 22:12:45]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2015-02-27 22:12:45]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/961533002/#ps60001 (title:
"Addressing feedback")

[commit-bot: I haz the power, 2015-02-27 22:13:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/961533002/60001

[commit-bot: I haz the power, 2015-02-27 23:16:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-27 23:17:03]

Patchset 4 (id:??) landed as
https://crrev.com/47869f0c6e63a26f450809111a9847c35fed7d81
Cr-Commit-Position: refs/heads/master@{#318537}