Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 961503002: Move argument parsing, add fields for missing flags (Closed)

Created:
5 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move argument parsing also to the options.dart file, adds fields for flags we were not storing in the CompilerOptions object. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/fc9f09065f8aac5575265b0aa1974beb9384b445

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -106 lines) Patch
M bin/devc.dart View 2 chunks +12 lines, -105 lines 0 comments Download
M lib/src/options.dart View 3 chunks +122 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-02-26 00:30:45 UTC) #3
vsm
lgtm
5 years, 9 months ago (2015-02-26 00:35:09 UTC) #4
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-02-26 00:40:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
fc9f09065f8aac5575265b0aa1974beb9384b445 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698