Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 961493003: don't run dart gen on JS patch code (Closed)

Created:
5 years, 10 months ago by Jennifer Messerly
Modified:
5 years, 10 months ago
Reviewers:
vsm, Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -2651 lines) Patch
M test/codegen_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M test/dart_codegen/expect/_internal/list.dart View 1 chunk +1 line, -4 lines 0 comments Download
M test/dart_codegen/expect/_internal/print.dart View 1 chunk +1 line, -3 lines 0 comments Download
M test/dart_codegen/expect/_internal/symbol.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/async/async View 1 chunk +0 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/async/deferred_load.dart View 1 chunk +1 line, -3 lines 0 comments Download
M test/dart_codegen/expect/async/schedule_microtask.dart View 1 chunk +1 line, -3 lines 0 comments Download
M test/dart_codegen/expect/async/timer.dart View 1 chunk +3 lines, -15 lines 0 comments Download
M test/dart_codegen/expect/async/zone.dart View 11 chunks +39 lines, -39 lines 0 comments Download
M test/dart_codegen/expect/collection/collection View 1 chunk +0 lines, -1582 lines 0 comments Download
M test/dart_codegen/expect/collection/hash_map.dart View 1 chunk +4 lines, -29 lines 0 comments Download
M test/dart_codegen/expect/collection/hash_set.dart View 1 chunk +3 lines, -28 lines 0 comments Download
M test/dart_codegen/expect/collection/linked_hash_map.dart View 1 chunk +4 lines, -29 lines 0 comments Download
M test/dart_codegen/expect/collection/linked_hash_set.dart View 1 chunk +3 lines, -28 lines 0 comments Download
M test/dart_codegen/expect/convert/convert View 2 chunks +0 lines, -248 lines 0 comments Download
M test/dart_codegen/expect/convert/json.dart View 8 chunks +13 lines, -29 lines 0 comments Download
M test/dart_codegen/expect/convert/utf.dart View 1 chunk +1 line, -3 lines 0 comments Download
M test/dart_codegen/expect/core/bool.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/core/core View 2 chunks +0 lines, -16 lines 0 comments Download
M test/dart_codegen/expect/core/date_time.dart View 1 chunk +16 lines, -49 lines 0 comments Download
M test/dart_codegen/expect/core/double.dart View 1 chunk +1 line, -5 lines 0 comments Download
M test/dart_codegen/expect/core/duration.dart View 1 chunk +6 lines, -7 lines 0 comments Download
M test/dart_codegen/expect/core/errors.dart View 3 chunks +5 lines, -52 lines 0 comments Download
M test/dart_codegen/expect/core/exceptions.dart View 4 chunks +11 lines, -11 lines 0 comments Download
M test/dart_codegen/expect/core/expando.dart View 1 chunk +3 lines, -16 lines 0 comments Download
M test/dart_codegen/expect/core/function.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M test/dart_codegen/expect/core/identical.dart View 1 chunk +2 lines, -8 lines 0 comments Download
M test/dart_codegen/expect/core/int.dart View 2 chunks +3 lines, -9 lines 0 comments Download
M test/dart_codegen/expect/core/iterable.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/core/list.dart View 1 chunk +3 lines, -37 lines 0 comments Download
M test/dart_codegen/expect/core/object.dart View 1 chunk +4 lines, -13 lines 0 comments Download
M test/dart_codegen/expect/core/regexp.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M test/dart_codegen/expect/core/stopwatch.dart View 2 chunks +4 lines, -11 lines 0 comments Download
M test/dart_codegen/expect/core/string.dart View 3 chunks +9 lines, -40 lines 0 comments Download
M test/dart_codegen/expect/core/string_buffer.dart View 2 chunks +6 lines, -16 lines 0 comments Download
M test/dart_codegen/expect/core/uri.dart View 27 chunks +71 lines, -77 lines 0 comments Download
M test/dart_codegen/expect/math/math View 1 chunk +11 lines, -158 lines 0 comments Download
M test/dart_codegen/expect/math/random.dart View 1 chunk +1 line, -2 lines 0 comments Download
M test/dart_codegen/expect/typed_data/typed_data View 19 chunks +41 lines, -60 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
The results were pretty nonsensical :) ... I think this was my fault, when I ...
5 years, 10 months ago (2015-02-25 23:13:53 UTC) #2
vsm
lgtm
5 years, 10 months ago (2015-02-26 15:55:48 UTC) #3
Jennifer Messerly
5 years, 10 months ago (2015-02-26 16:07:25 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f82ee485a682fed9a82f524861a69a1286f9eb51 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698